Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 3.0.x into 3.1.x #4482

Merged
merged 39 commits into from
Jan 14, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
adce7a9
Release 2.12.1
morozov Nov 14, 2020
faf8ddd
Bump version to 2.12.2-DEV
morozov Nov 14, 2020
51bd65b
Update documentation after the 3.0.0 release
morozov Nov 15, 2020
996ab03
Merge pull request #4435 from morozov/update-readme
morozov Nov 16, 2020
1a5be85
Upgrade phpstan and psalm
simPod Nov 6, 2020
79cba0b
Merge pull request #4412 from simPod/upgrade
morozov Nov 16, 2020
47aaf42
Replace DriverManager::$_driverMap with a constant
morozov Nov 24, 2020
9eedbe9
Refactor DriverManager::_checkParams()
morozov Nov 24, 2020
97ef20c
Handle connection password as optional in OracleSchemaManager
morozov Nov 25, 2020
70793ec
Handle connection driver parameter as optional in PrimaryReadReplicaC…
morozov Nov 25, 2020
930b906
Connection database name cannot be NULL
morozov Nov 25, 2020
2e88bef
Do not rely on optional parameters in SqliteSchemaManager
morozov Nov 25, 2020
de5464d
Document the shape of the connection parameters array
morozov Nov 25, 2020
caf5c0f
Ensure the default is declared in the same statement for new columns
duncan3dc Nov 24, 2020
2d1f747
Merge pull request #4447 from duncan3dc/sql-server-add-column-default
morozov Nov 25, 2020
4b46ecd
Merge pull request #4449 from morozov/params-shape
morozov Nov 25, 2020
bd5fc0d
Merge branch '2.12.x' into 3.0.x
morozov Nov 25, 2020
c098382
No need of comma
kishore-hariram Sep 30, 2019
ecadac4
Merge pull request #3682 from kikilass/master
morozov Nov 28, 2020
a7b5f09
Remove unmaintained branches from the project metadata
morozov Nov 29, 2020
98233ab
Merge pull request #4453 from morozov/remove-unmaintained-branches
morozov Nov 29, 2020
7aac084
MSSQL adds a redundant ORDER BY clause when with subquery with ORDER BY
trusek Nov 17, 2020
5a7befb
Merge pull request #4438 from trusek/2.12.x
morozov Dec 7, 2020
a0b82ff
Fix and improve docs
greeflas Sep 7, 2020
373c24d
Merge pull request #4260 from greeflas/fix_docs
morozov Dec 7, 2020
2119044
Add note about lost connections to UPGRADE guide.
beberlei Dec 7, 2020
7f6acbb
Merge pull request #4457 from beberlei/LostConnectionHint
greg0ire Dec 8, 2020
4fb1862
Use the ramsey/composer-install action to install dependencies
nicwortel Dec 12, 2020
4211e3c
Merge pull request #4463 from nicwortel/ramsey-composer-install
greg0ire Dec 13, 2020
f5984e1
Update PHPUnit to 9.5
morozov Dec 13, 2020
5ffd105
Merge pull request #4466 from morozov/phpunit-9.5
morozov Dec 13, 2020
b40e327
Remove composer.lock from version control
nicwortel Dec 12, 2020
02fbb3d
Require the exact versions of development tools
nicwortel Dec 26, 2020
ce3421e
Merge pull request #4464 from nicwortel/remove-composer-lock
greg0ire Jan 7, 2021
78d4590
Merge remote-tracking branch 'origin/2.12.x' into 3.0.x
greg0ire Jan 7, 2021
d01c726
Document possibly null property as such
greg0ire Jan 7, 2021
2f16c00
Remove redundant casts
greg0ire Jan 7, 2021
8acf030
Upgrade Psalm to 4.3.2
greg0ire Jan 7, 2021
db6f73c
Ignore false positive
greg0ire Jan 7, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 5 additions & 13 deletions .doctrine-project.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,57 +9,49 @@
"name": "3.0",
"branchName": "3.0.x",
"slug": "latest",
"upcoming": true
},
{
"name": "2.12",
"branchName": "2.12.x",
"slug": "2.12",
"current": true,
"aliases": [
"current",
"stable"
]
},
{
"name": "2.12",
"branchName": "2.12.x",
"slug": "2.12"
},
{
"name": "2.11",
"branchName": "2.11.x",
"slug": "2.11",
"maintained": false
},
{
"name": "2.10",
"branchName": "2.10.x",
"slug": "2.10",
"maintained": false
},
{
"name": "2.9",
"branchName": "2.9",
"slug": "2.9",
"maintained": false
},
{
"name": "2.8",
"branchName": "2.8",
"slug": "2.8",
"maintained": false
},
{
"name": "2.7",
"branchName": "2.7",
"slug": "2.7",
"maintained": false
},
{
"name": "2.6",
"branchName": "2.6",
"slug": "2.6",
"maintained": false
},
{
"name": "2.5",
"branchName": "2.5",
"slug": "2.5",
"maintained": false
}
Expand Down
2 changes: 1 addition & 1 deletion .gitattributes
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
/.appveyor.yml export-ignore
/ci export-ignore
/composer.lock export-ignore
/docs export-ignore
/.doctrine-project.json export-ignore
/.gitattributes export-ignore
Expand All @@ -9,6 +8,7 @@
/phpcs.xml.dist export-ignore
/phpstan.neon.dist export-ignore
/phpunit.xml.dist export-ignore
/psalm.xml.dist export-ignore
/run-all.sh export-ignore
/SECURITY.md export-ignore
/tests export-ignore
Expand Down
9 changes: 1 addition & 8 deletions .github/workflows/coding-standards.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,15 +31,8 @@ jobs:
php-version: "${{ matrix.php-version }}"
tools: "cs2pr"

- name: "Cache dependencies installed with Composer"
uses: "actions/cache@v2"
with:
path: "~/.composer/cache"
key: "php-${{ matrix.php-version }}-composer-locked-${{ hashFiles('composer.lock') }}"
restore-keys: "php-${{ matrix.php-version }}-composer-locked-"

- name: "Install dependencies with Composer"
run: "composer install --no-interaction --no-progress --no-suggest"
uses: "ramsey/composer-install@v1"

# https://github.com/doctrine/.github/issues/3
- name: "Run PHP_CodeSniffer"
Expand Down
112 changes: 24 additions & 88 deletions .github/workflows/continuous-integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,10 @@ jobs:
- "7.3"
- "7.4"
- "8.0"
deps:
- "fixed"
dependencies:
- "highest"
include:
- deps: "low"
- dependencies: "lowest"
php-version: "7.3"

steps:
Expand All @@ -46,20 +46,10 @@ jobs:
coverage: "pcov"
ini-values: "zend.assertions=1"

- name: "Cache dependencies installed with composer"
uses: "actions/cache@v2"
- name: "Install dependencies with Composer"
uses: "ramsey/composer-install@v1"
with:
path: "~/.composer/cache"
key: "php-${{ matrix.php-version }}-composer-locked-${{ hashFiles('composer.lock') }}"
restore-keys: "php-${{ matrix.php-version }}-composer-locked-"

- name: "Install dependencies with composer"
run: "composer install --no-interaction --no-progress --no-suggest"
if: "${{ matrix.deps == 'fixed' }}"

- name: "Install lowest possible dependencies with composer"
run: "composer update --no-interaction --no-progress --no-suggest --prefer-dist --prefer-lowest"
if: "${{ matrix.deps == 'low' }}"
dependency-versions: "${{ matrix.dependencies }}"

- name: "Run PHPUnit"
run: "vendor/bin/phpunit -c ci/github/phpunit/sqlite.xml --coverage-clover=coverage.xml"
Expand Down Expand Up @@ -101,15 +91,8 @@ jobs:
coverage: "pcov"
ini-values: "zend.assertions=1"

- name: "Cache dependencies installed with composer"
uses: "actions/cache@v2"
with:
path: "~/.composer/cache"
key: "php-${{ matrix.php-version }}-composer-locked-${{ hashFiles('composer.lock') }}"
restore-keys: "php-${{ matrix.php-version }}-composer-locked-"

- name: "Install dependencies with composer"
run: "composer install --no-interaction --no-progress --no-suggest"
- name: "Install dependencies with Composer"
uses: "ramsey/composer-install@v1"

- name: "Run PHPUnit"
run: "vendor/bin/phpunit -c ci/github/phpunit/oci8.xml --coverage-clover=coverage.xml"
Expand Down Expand Up @@ -151,15 +134,8 @@ jobs:
coverage: "pcov"
ini-values: "zend.assertions=1"

- name: "Cache dependencies installed with composer"
uses: "actions/cache@v2"
with:
path: "~/.composer/cache"
key: "php-${{ matrix.php-version }}-composer-locked-${{ hashFiles('composer.lock') }}"
restore-keys: "php-${{ matrix.php-version }}-composer-locked-"

- name: "Install dependencies with composer"
run: "composer install --no-interaction --no-progress --no-suggest"
- name: "Install dependencies with Composer"
uses: "ramsey/composer-install@v1"

- name: "Run PHPUnit"
run: "vendor/bin/phpunit -c ci/github/phpunit/pdo_oci.xml --coverage-clover=coverage.xml"
Expand Down Expand Up @@ -211,15 +187,8 @@ jobs:
coverage: "pcov"
ini-values: "zend.assertions=1"

- name: "Cache dependencies installed with composer"
uses: "actions/cache@v2"
with:
path: "~/.composer/cache"
key: "php-${{ matrix.php-version }}-composer-locked-${{ hashFiles('composer.lock') }}"
restore-keys: "php-${{ matrix.php-version }}-composer-locked-"

- name: "Install dependencies with composer"
run: "composer install --no-interaction --no-progress --no-suggest"
- name: "Install dependencies with Composer"
uses: "ramsey/composer-install@v1"

- name: "Run PHPUnit"
run: "vendor/bin/phpunit -c ci/github/phpunit/pdo_pgsql.xml --coverage-clover=coverage.xml"
Expand Down Expand Up @@ -281,15 +250,8 @@ jobs:
ini-values: "zend.assertions=1"
extensions: "${{ matrix.extension }}"

- name: "Cache dependencies installed with composer"
uses: "actions/cache@v2"
with:
path: "~/.composer/cache"
key: "php-${{ matrix.php-version }}-composer-locked-${{ hashFiles('composer.lock') }}"
restore-keys: "php-${{ matrix.php-version }}-composer-locked-"

- name: "Install dependencies with composer"
run: "composer install --no-interaction --no-progress --no-suggest"
- name: "Install dependencies with Composer"
uses: "ramsey/composer-install@v1"

- name: "Run PHPUnit"
run: "vendor/bin/phpunit -c ci/github/phpunit/${{ matrix.extension }}.xml --coverage-clover=coverage.xml"
Expand Down Expand Up @@ -377,15 +339,8 @@ jobs:
ini-values: "zend.assertions=1"
extensions: "${{ matrix.extension }}"

- name: "Cache dependencies installed with composer"
uses: "actions/cache@v2"
with:
path: "~/.composer/cache"
key: "php-${{ matrix.php-version }}-composer-locked-${{ hashFiles('composer.lock') }}"
restore-keys: "php-${{ matrix.php-version }}-composer-locked-"

- name: "Install dependencies with composer"
run: "composer install --no-interaction --no-progress --no-suggest"
- name: "Install dependencies with Composer"
uses: "ramsey/composer-install@v1"

- name: "Copy TLS-related files"
run: 'docker cp "${{ job.services.mysql.id }}:/var/lib/mysql/ca.pem" . && docker cp "${{ job.services.mysql.id }}:/var/lib/mysql/client-cert.pem" . && docker cp "${{ job.services.mysql.id }}:/var/lib/mysql/client-key.pem" .'
Expand Down Expand Up @@ -453,15 +408,8 @@ jobs:
tools: "pecl"
extensions: "${{ matrix.extension }}-5.9.0preview1"

- name: "Cache dependencies installed with composer"
uses: "actions/cache@v2"
with:
path: "~/.composer/cache"
key: "php-${{ matrix.php-version }}-composer-locked-${{ hashFiles('composer.lock') }}"
restore-keys: "php-${{ matrix.php-version }}-composer-locked-"

- name: "Install dependencies with composer"
run: "composer install --no-interaction --no-progress --no-suggest"
- name: "Install dependencies with Composer"
uses: "ramsey/composer-install@v1"

- name: "Run PHPUnit"
run: "vendor/bin/phpunit -c ci/github/phpunit/${{ matrix.extension }}.xml --coverage-clover=coverage.xml"
Expand Down Expand Up @@ -518,15 +466,8 @@ jobs:
- name: "Install ibm_db2 extension"
run: "ci/github/ext/install-ibm_db2.sh ${{ matrix.php-version }}"

- name: "Cache dependencies installed with composer"
uses: "actions/cache@v2"
with:
path: "~/.composer/cache"
key: "php-${{ matrix.php-version }}-composer-locked-${{ hashFiles('composer.lock') }}"
restore-keys: "php-${{ matrix.php-version }}-composer-locked-"

- name: "Install dependencies with composer"
run: "composer install --no-interaction --no-progress --no-suggest"
- name: "Install dependencies with Composer"
uses: "ramsey/composer-install@v1"

- name: "Run PHPUnit"
run: "vendor/bin/phpunit -c ci/github/phpunit/ibm_db2.xml --coverage-clover=coverage.xml"
Expand Down Expand Up @@ -556,18 +497,13 @@ jobs:
with:
php-version: "${{ matrix.php-version }}"

- name: "Cache dependencies installed with composer"
uses: "actions/cache@v2"
with:
path: "~/.composer/cache"
key: "php-${{ matrix.php-version }}-composer-locked-${{ hashFiles('composer.lock') }}"
restore-keys: "php-${{ matrix.php-version }}-composer-locked-"

- name: "Lower minimum stability"
run: "composer config minimum-stability dev"

- name: "Install development dependencies with composer"
run: "composer update --no-interaction --no-progress --no-suggest --prefer-dist"
- name: "Install development dependencies with Composer"
uses: "ramsey/composer-install@v1"
with:
composer-options: "--prefer-dist"

- name: "Run PHPUnit"
run: "vendor/bin/phpunit -c ci/github/phpunit/sqlite.xml"
Expand Down
15 changes: 5 additions & 10 deletions .github/workflows/static-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,15 +32,8 @@ jobs:
php-version: "${{ matrix.php-version }}"
tools: "cs2pr"

- name: "Cache dependencies installed with composer"
uses: "actions/cache@v2"
with:
path: "~/.composer/cache"
key: "php-${{ matrix.php-version }}-composer-locked-${{ hashFiles('composer.lock') }}"
restore-keys: "php-${{ matrix.php-version }}-composer-locked-"

- name: "Install dependencies with composer"
run: "composer install --no-interaction --no-progress --no-suggest"
- name: "Install dependencies with Composer"
uses: "ramsey/composer-install@v1"

- name: "Run a static analysis with phpstan/phpstan"
run: "vendor/bin/phpstan analyse --error-format=checkstyle | cs2pr"
Expand All @@ -59,4 +52,6 @@ jobs:
uses: actions/checkout@v2

- name: Psalm
uses: docker://vimeo/psalm-github-actions:3.17.2
uses: docker://vimeo/psalm-github-actions:4.1.1
env:
REQUIRE_DEV: "true"
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/composer.lock
/.phpunit.result.cache
build/
logs/
Expand All @@ -9,3 +10,4 @@ vendor/
/phpunit.xml
/.phpcs-cache
/phpstan.neon
/psalm.xml
21 changes: 15 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
# Doctrine DBAL

| [Master][Master] | [2.12][2.12] |
|:----------------:|:----------:|
| [![Build status][Master image]][Master] | [![Build status][2.12 image]][2.12] |
| [![GitHub Actions][GA master image]][GA master] | [![GitHub Actions][GA 2.12 image]][GA 2.12] |
| [![AppVeyor][AppVeyor master image]][AppVeyor master] | [![AppVeyor][AppVeyor 2.12 image]][AppVeyor 2.12] |
| [![Code Coverage][Coverage image]][CodeCov Master] | [![Code Coverage][Coverage 2.12 image]][CodeCov 2.12] |
| [4.0-dev][Master] | [3.0][3.0] | [2.12][2.12] |
|:----------------:|:----------:|:----------:|
| [![Build status][Master image]][Master] | [![Build status][3.0 image]][3.0] | [![Build status][2.12 image]][2.12] |
| [![GitHub Actions][GA master image]][GA master] | [![GitHub Actions][GA 3.0 image]][GA 3.0] | [![GitHub Actions][GA 2.12 image]][GA 2.12] |
| [![AppVeyor][AppVeyor master image]][AppVeyor master] | [![AppVeyor][AppVeyor 3.0 image]][AppVeyor 3.0] | [![AppVeyor][AppVeyor 2.12 image]][AppVeyor 2.12] |
| [![Code Coverage][Coverage image]][CodeCov Master] | [![Code Coverage][Coverage 3.0 image]][CodeCov 3.0] | [![Code Coverage][Coverage 2.12 image]][CodeCov 2.12] |

Powerful database abstraction layer with many features for database schema introspection, schema management and PDO abstraction.

Expand All @@ -24,6 +24,15 @@ Powerful database abstraction layer with many features for database schema intro
[GA master]: https://github.com/doctrine/dbal/actions?query=workflow%3A%22Continuous+Integration%22+branch%3Amaster
[GA master image]: https://github.com/doctrine/dbal/workflows/Continuous%20Integration/badge.svg

[3.0 image]: https://img.shields.io/travis/doctrine/dbal/3.0.x.svg?style=flat-square
[Coverage 3.0 image]: https://codecov.io/gh/doctrine/dbal/branch/3.0.x/graph/badge.svg
[3.0]: https://github.com/doctrine/dbal/tree/3.0.x
[CodeCov 3.0]: https://codecov.io/gh/doctrine/dbal/branch/3.0.x
[AppVeyor 3.0]: https://ci.appveyor.com/project/doctrine/dbal/branch/3.0.x
[AppVeyor 3.0 image]: https://ci.appveyor.com/api/projects/status/i88kitq8qpbm0vie/branch/3.0.x?svg=true
[GA 3.0]: https://github.com/doctrine/dbal/actions?query=workflow%3A%22Continuous+Integration%22+branch%3A3.0.x
[GA 3.0 image]: https://github.com/doctrine/dbal/workflows/Continuous%20Integration/badge.svg?branch=3.0.x

[2.12 image]: https://img.shields.io/travis/doctrine/dbal/2.12.x.svg?style=flat-square
[Coverage 2.12 image]: https://codecov.io/gh/doctrine/dbal/branch/2.12.x/graph/badge.svg
[2.12]: https://github.com/doctrine/dbal/tree/2.12.x
Expand Down
2 changes: 1 addition & 1 deletion SECURITY.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Security
The Doctrine library is operating very close to your database and as such needs
to handle and make assumptions about SQL injection vulnerabilities.

It is vital that you understand how Doctrine approaches security, because
It is vital that you understand how Doctrine approaches security because
we cannot protect you from SQL injection.

Please read the documentation chapter on Security in Doctrine DBAL to
Expand Down
3 changes: 2 additions & 1 deletion UPGRADE.md
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,8 @@ All drivers must implement the `convertException()` method which is now part of

## The `PingableConnection` interface is removed

The functionality of pinging the server is no longer supported.
The functionality of pinging the server is no longer supported. Lost
connections are now automatically reconnected by Doctrine internally.

## BC BREAK: Deprecated driver-level classes and interfaces are removed.

Expand Down
12 changes: 6 additions & 6 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,14 +37,14 @@
"doctrine/event-manager": "^1.0"
},
"require-dev": {
"doctrine/coding-standard": "^8.1",
"jetbrains/phpstorm-stubs": "^2019.1",
"phpstan/phpstan": "^0.12.40",
"doctrine/coding-standard": "8.2.0",
"jetbrains/phpstorm-stubs": "2019.3",
"phpstan/phpstan": "0.12.57",
"phpstan/phpstan-strict-rules": "^0.12.2",
"phpunit/phpunit": "^9.4",
"psalm/plugin-phpunit": "^0.10.0",
"phpunit/phpunit": "9.5.0",
"psalm/plugin-phpunit": "0.13.0",
"symfony/console": "^2.0.5|^3.0|^4.0|^5.0",
"vimeo/psalm": "^3.17.2"
"vimeo/psalm": "4.3.2"
},
"suggest": {
"symfony/console": "For helpful console commands such as SQL execution and import of files."
Expand Down
Loading