Upgrade phpstan and psalm

[simPod]

Q	A
Type	improvement
BC Break	no
Fixed issues

Summary

In order to fix issues related but not explicitly caused by #4403

[morozov]

Please retarget against 2.12.x.

[greg0ire]

@morozov should we drop the ^ part here? that way we avoid discrepancies between local runs and CI (at the cost of a warning from Composer I think)

[ciaranmcnulty]

The ^ doesn’t block later versions so why a warning?

[greg0ire]

I checked and you are right, there is no warning. Maybe that changed, or I have faulty memory. That said, I was proposing to remove the ^, that's when I thought you would get a warning, you won't get a warning with it that's for sure.

[morozov]

Maybe that changed, or I have faulty memory.

No, Composer would definitely trigger a warning in some cases if some dependency constraint was declared as a specific version.

should we drop the ^ part here?

Why now? The specific version is locked in the lock file which we still commit to Git. I believe it should be done separately from this specific upgrade.

[greg0ire]

I wasn't require we do it now, but in general. Now would be as good a time as any.

[morozov]

Now would be as good a time as any.

The way how we manage development dependencies is for the most part initiated by the work being done in #4386 which seems stuck. Once we decide to make a change, we'll make it for all dependencies at once.

This patch comes from an external contributor and just updates a dependency. I don't see much point in increasing the scope.

[morozov]

Thanks, @simPod.

[simPod]

Thanks for patience with reviews :)