Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix php8 mysql mariadb #4396

Merged
merged 1 commit into from
Nov 1, 2020
Merged

Conversation

greg0ire
Copy link
Member

@greg0ire greg0ire commented Oct 31, 2020

The only thing that I could find that looks related is this: php/php-src@5075240

I think getting a warning in lower PHP versions instead of an exception although we configure PDO to throw might be a bug, and I think the commit above might have for side effect to fix that bug.

@greg0ire greg0ire force-pushed the fix-php8-mysql-mariadb branch from 843a2bc to a7bb6c2 Compare October 31, 2020 22:37
When using PDO, an exception is supposed to be thrown since we are using
the error mode that behaves that way. It only seems to be the case since
PHP 8 though.
@greg0ire greg0ire force-pushed the fix-php8-mysql-mariadb branch from a7bb6c2 to 09eafbc Compare October 31, 2020 22:46
@greg0ire greg0ire marked this pull request as ready for review October 31, 2020 22:54
@greg0ire greg0ire requested a review from morozov October 31, 2020 22:55
@greg0ire
Copy link
Member Author

Not sure if I picked the right labels, CI might be wrong.

Copy link
Member

@morozov morozov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@morozov morozov added PHP PDO and removed CI labels Nov 1, 2020
@morozov morozov added this to the 2.12.1 milestone Nov 1, 2020
@morozov morozov merged commit b8665ec into doctrine:2.12.x Nov 1, 2020
@greg0ire greg0ire deleted the fix-php8-mysql-mariadb branch November 1, 2020 09:08
rgrellmann added a commit to Rossmann-IT/dbal that referenced this pull request Mar 7, 2021
Release [2.12.1](https://github.com/doctrine/dbal/milestone/84)

2.12.1
======

- Total issues resolved: **2**
- Total pull requests resolved: **11**
- Total contributors: **7**

Documentation,Prepared Statements
---------------------------------

 - [4424: Mark SQLParserUtils internal](doctrine#4424) thanks to @morozov

Packaging
---------

 - [4416: Update .gitattributes](doctrine#4416) thanks to @bytestream

Bug,Cache
---------

 - [4414: ResultCacheStatement::fetchAllAssociative does not store results in cache](doctrine#4414) thanks to @morozov and @dFayet

Deprecation,Prepared Statements
-------------------------------

 - [4411: Deprecate inappropriate usage of prepared statement parameters](doctrine#4411) thanks to @morozov
 - [4407: Deprecate colon prefix for prepared statement parameters](doctrine#4407) thanks to @morozov

Static Analysis
---------------

 - [4403: Remove redundant phpstan param from DriverManager::getConnection()](doctrine#4403) thanks to @simPod

Bug,Locking,Transactions
------------------------

 - [4400: LockMode::NONE should not set WITH (NOLOCK)](doctrine#4400) thanks to @BenMorel

Code Style,PHP
--------------

 - [4398: Update PHP&doctrine#95;CodeSniffer to 3.5.8](doctrine#4398) thanks to @morozov

PDO,PHP,Test Suite
------------------

 - [4396: Fix php8 mysql mariadb](doctrine#4396) thanks to @greg0ire

Documentation
-------------

 - [4390: Fix headline in the upgrade docs](doctrine#4390) thanks to @jdreesen

Documentation,Testing
---------------------

 - [4356: Testing Guidelines](doctrine#4356) thanks to @morozov

# gpg: Signature made Sat Nov 14 21:50:01 2020
# gpg:                using DSA key 1BEDEE0A820BC30D858F9F0C2C3A645671828132
# gpg: Can't check signature: No public key

# Conflicts:
#	README.md
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants