Remove workaround in PDOSqlsrv\Connection::quote()

[morozov]

Q	A
Type	bug
BC Break	no

The workaround for PDOSqlsrv\Connection::quote() added in fdcae5d w/o any tests is no longer needed and breaks valid code:

$conn = DriverManager::getConnection([
    'driver' => 'pdo_sqlsrv',
    'user' => 'sa',
    'password' => 'Passw0rd',
]);

var_dump(
    $conn->fetchColumn('SELECT ' . $conn->quote("\0"))
);

// SQLSTATE[42000]: [Microsoft][ODBC Driver 17 for SQL Server][SQL Server]Unclosed quotation mark after the character string '.'.

The expected result is:

string(1) "\000"

The workaround looks related to microsoft/msphpsql#538 which was fixed by microsoft/msphpsql#550 in pdo_sqlsrv 5.1.1. The oldest pdo_sqlsrv version that supports PHP 7.2 is 5.2.1.

No test provided since this is not a special case from the DBAL perspective and should be handled by the underlying driver.

[joelharkes]

Thanks for the fix! this fixed our bug too :)