Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PHPStan to 0.12.31 #4116

Merged
merged 1 commit into from
Jun 27, 2020
Merged

Update PHPStan to 0.12.31 #4116

merged 1 commit into from
Jun 27, 2020

Conversation

morozov
Copy link
Member

@morozov morozov commented Jun 27, 2020

Q A
Type improvement
BC Break no

The update has fixes for phpstan/phpstan-src#255 and phpstan/phpstan#3527.

Besides the error suppression removed in this PR, it will allow removing one more in 2.11.x:

dbal/phpstan.neon.dist

Lines 22 to 25 in 50dd0ef

# https://github.com/phpstan/phpstan/issues/3527
-
message: '~^Call to private method sqliteCreateFunction\(\) of parent class PDO\.$~'
path: %currentWorkingDirectory%/lib/Doctrine/DBAL/Driver/PDOSqlite/Driver.php

@morozov morozov added this to the 2.10.3 milestone Jun 27, 2020
@morozov morozov requested a review from greg0ire June 27, 2020 02:11
@morozov morozov merged commit f55bdb4 into doctrine:2.10.x Jun 27, 2020
@morozov morozov deleted the phpstan-0.12.31 branch June 27, 2020 07:50
@morozov morozov self-assigned this Jun 27, 2020
@morozov morozov mentioned this pull request Jun 27, 2020
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@greg0ire greg0ire greg0ire approved these changes

Assignees

@morozov morozov

Labels
Improvement Static Analysis
Projects
None yet
Milestone
2.10.3
Development

Successfully merging this pull request may close these issues.
2 participants
@morozov @greg0ire