Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the suppressed errors that PHPStan no longer reports #4107

Merged
merged 1 commit into from
Jun 25, 2020
Merged

Remove the suppressed errors that PHPStan no longer reports #4107

merged 1 commit into from
Jun 25, 2020

Conversation

morozov
Copy link
Member

@morozov morozov commented Jun 25, 2020

Q A
Type improvement
BC Break no

@morozov morozov added this to the 3.0.0 milestone Jun 25, 2020
@greg0ire
Copy link
Member

Do you know why reportUnmatchedIgnoredErrors was originally set to false in #3025 ?

@morozov
Copy link
Member Author

morozov commented Jun 25, 2020

Do you know why reportUnmatchedIgnoredErrors was originally set to false in #3025 ?

Because some errors are only reported in the absence of the corresponding PHP extensions.

@morozov morozov merged commit 92ba48c into doctrine:3.0.x Jun 25, 2020
@morozov morozov deleted the phpstan-irrelevant-suppressions branch June 25, 2020 19:51
@morozov morozov self-assigned this Jun 27, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@greg0ire greg0ire greg0ire approved these changes

Assignees

@morozov morozov

Labels
Improvement Static Analysis
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@morozov @greg0ire