Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flatten source and test directory structure #3915

Merged
merged 8 commits into from
Mar 26, 2020
Merged

Flatten source and test directory structure #3915

merged 8 commits into from
Mar 26, 2020

Conversation

morozov
Copy link
Member

@morozov morozov commented Mar 21, 2020 •
edited
Loading

Q A
Type improvement
BC Break no

TODO:

  • Move source files from lib/Doctrine/DBAL to src/.
  • Move CI-related files from tests/ to ci/.
  • Get rid of the DbalTestCase class.
  • Remove the Dbal prefix from abstract test classes.
  • Move test files from tests/Doctrine/Tests/DBAL to tests/.
  • Rename the Doctrine\Tests\DBAL namespace to Doctrine\DBAL\Tests.
  • Reconfigure ContinuousPHP to pick up the new PHPUnit configuration path.

@morozov morozov added the WIP label Mar 21, 2020
@morozov morozov added Improvement and removed WIP labels Mar 21, 2020
@morozov morozov added this to the 3.0.0 milestone Mar 21, 2020
@morozov morozov requested a review from a team March 21, 2020 22:38
@morozov morozov mentioned this pull request Mar 22, 2020
Merged
greg0ire
greg0ire approved these changes Mar 22, 2020
View reviewed changes
Copy link
Member

@greg0ire greg0ire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

SenseException
SenseException approved these changes Mar 26, 2020
View reviewed changes
Copy link
Member

@SenseException SenseException left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet.

@morozov morozov merged commit 6162910 into doctrine:3.0.x Mar 26, 2020
@morozov morozov deleted the psr-4 branch March 26, 2020 19:10
@morozov
Copy link
Member Author

morozov commented Mar 26, 2020

Now it's time to merge 3.0.x into master 🤣

@morozov morozov mentioned this pull request Mar 26, 2020
Merged
1 task
@morozov morozov self-assigned this Mar 30, 2020
@morozov morozov mentioned this pull request May 30, 2020
Merged
@morozov morozov mentioned this pull request Feb 28, 2022
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SenseException SenseException SenseException approved these changes

@greg0ire greg0ire greg0ire approved these changes

Assignees

@morozov morozov

Labels
CI Improvement Test Suite
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@morozov @greg0ire @SenseException