Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix documented return type #3816

Merged
merged 1 commit into from
Jan 10, 2020
Merged

Fix documented return type #3816

merged 1 commit into from
Jan 10, 2020

Conversation

BenMorel
Copy link
Contributor

Q A
Type improvement
BC Break no
Fixed issues none

Summary

diffTable() returns null if no differences, not false.

@morozov morozov added this to the 4.0.0 milestone Jan 10, 2020
@morozov morozov merged commit 69cd77e into doctrine:master Jan 10, 2020
@morozov
Copy link
Member

morozov commented Jan 10, 2020

Thanks, @BenMorel!

@morozov morozov self-assigned this Jan 22, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@morozov morozov morozov approved these changes

Assignees

@morozov morozov

Labels
Bug Documentation
Projects
None yet
Milestone
4.0.0-beta1
Development

Successfully merging this pull request may close these issues.
2 participants
@BenMorel @morozov