Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PingableConnection and ServerInfoAwareConnection now extend Connection #3752

Merged
merged 1 commit into from
Nov 28, 2019
Merged

PingableConnection and ServerInfoAwareConnection now extend Connection #3752

merged 1 commit into from
Nov 28, 2019

Conversation

morozov
Copy link
Member

@morozov morozov commented Nov 28, 2019 •
edited
Loading

Q A
Type improvement
BC Break yes
Fixed issues job #617974029

The PingableConnection and ServerInfoAwareConnection interfaces should extend Connection, same as in #3746.

@morozov morozov added this to the 3.0.0 milestone Nov 28, 2019
@morozov morozov force-pushed the pingable-server-info-aware-connection branch from 826643b to b605056 Compare November 28, 2019 01:01
@morozov morozov force-pushed the pingable-server-info-aware-connection branch from b605056 to 9d2873e Compare November 28, 2019 01:08
@morozov morozov removed the WIP label Nov 28, 2019
@morozov morozov requested review from Ocramius and lcobucci November 28, 2019 02:02
@lcobucci lcobucci merged commit f97ee38 into doctrine:master Nov 28, 2019
@lcobucci lcobucci self-assigned this Nov 28, 2019
@morozov morozov deleted the pingable-server-info-aware-connection branch November 28, 2019 16:10
@morozov morozov mentioned this pull request Mar 17, 2020
Merged
4 tasks
@morozov morozov modified the milestones: 4.0.0, 3.0.0 Mar 17, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@greg0ire greg0ire greg0ire approved these changes

@lcobucci lcobucci lcobucci approved these changes

@Ocramius Ocramius Awaiting requested review from Ocramius

Assignees

@lcobucci lcobucci

Labels
BC Break Connections Improvement
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@morozov @lcobucci @greg0ire