Remove phpunit-bridge specific annotations #3719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The phpunit-bridge has been removed in doctrine#3643, so these no longer serve any purpose. The tests themselves are kept since they check that there is no crash when using an unknown option, and do not need a phpunit assertion to do so.
morozov
approved these changes
Nov 6, 2019
lcobucci
reviewed
Nov 7, 2019
| @@ -28,10 +28,6 @@ protected function setUp() : void | |||
| $this->connection->getSchemaManager()->dropAndCreateTable($table); | |||
| } | |||
|
|
|||
| /** | |||
| * @group legacy | |||
There was a problem hiding this comment.
@group is from PHPUnit, though.
There was a problem hiding this comment.
I thought we were using that group to identify the tests we were going to drop eventually because of legacy 😆
There was a problem hiding this comment.
Wouldn't be a bad idea, but right now I bet it's far from being exhaustive :P
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The phpunit-bridge has been removed in #3643, so these no longer serve
any purpose. The tests themselves are kept since they check that there
is no crash when using an unknown option, and do not need a phpunit
assertion to do so.