Make sure that (VAR)CHAR column length is specified in characters, not bytes #3599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morozov
changed the title
jwage
approved these changes
Jun 7, 2019
morozov
added a commit
that referenced
this pull request
Jun 13, 2019
Make sure that (VAR)CHAR column length is specified in characters, not bytes
morozov
added a commit
that referenced
this pull request
Jun 27, 2019
Make sure that (VAR)CHAR column length is specified in characters, not bytes
morozov
added a commit
that referenced
this pull request
Jun 27, 2019
Make sure that (VAR)CHAR column length is specified in characters, not bytes
morozov
added a commit
that referenced
this pull request
Jun 27, 2019
Make sure that (VAR)CHAR column length is specified in characters, not bytes
morozov
added a commit
to morozov/dbal
that referenced
this pull request
Aug 26, 2019
Make sure that (VAR)CHAR column length is specified in characters, not bytes
morozov
added a commit
to morozov/dbal
that referenced
this pull request
Aug 26, 2019
Make sure that (VAR)CHAR column length is specified in characters, not bytes
morozov
added a commit
to morozov/dbal
that referenced
this pull request
Aug 26, 2019
Make sure that (VAR)CHAR column length is specified in characters, not bytes
morozov
added a commit
to morozov/dbal
that referenced
this pull request
Aug 27, 2019
Make sure that (VAR)CHAR column length is specified in characters, not bytes
morozov
added a commit
that referenced
this pull request
Nov 2, 2019
Make sure that (VAR)CHAR column length is specified in characters, not bytes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added testing with Unicode strings to make sure the target column length is defined in characters.