-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforced parameter and return value types in Driver classes #3560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
reviewed
May 25, 2019
Thank you @greg0ire. I wish I could use Grammarly with PhpStorm. |
jwage
approved these changes
May 25, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hooray!
morozov
added a commit
to morozov/dbal
that referenced
this pull request
May 31, 2019
Enforced parameter and return value types in Driver classes
morozov
added a commit
to morozov/dbal
that referenced
this pull request
May 31, 2019
Enforced parameter and return value types in Driver classes
morozov
added a commit
to morozov/dbal
that referenced
this pull request
May 31, 2019
Enforced parameter and return value types in Driver classes
morozov
added a commit
to morozov/dbal
that referenced
this pull request
May 31, 2019
Enforced parameter and return value types in Driver classes
morozov
added a commit
that referenced
this pull request
Jun 13, 2019
Enforced parameter and return value types in Driver classes
morozov
added a commit
that referenced
this pull request
Jun 27, 2019
Enforced parameter and return value types in Driver classes
morozov
added a commit
that referenced
this pull request
Jun 27, 2019
Enforced parameter and return value types in Driver classes
morozov
added a commit
that referenced
this pull request
Jun 27, 2019
Enforced parameter and return value types in Driver classes
morozov
added a commit
to morozov/dbal
that referenced
this pull request
Aug 26, 2019
Enforced parameter and return value types in Driver classes
morozov
added a commit
to morozov/dbal
that referenced
this pull request
Aug 27, 2019
Enforced parameter and return value types in Driver classes
morozov
added a commit
that referenced
this pull request
Nov 2, 2019
Enforced parameter and return value types in Driver classes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rationale behind the breaking changes is the following:
$username
or$password
, therefore if we allow NULL, we'll have to replace it with an empty string in most of the implementation. At the same time, fro the drivers which support NULL (e.g. PDO) there's no difference between NULL and empty string.mysqli
,pdo_mysql
,pdo_sqlite
) allow establishing a connection without selecting a database, therefore it should be possible to indicate the absence of a value ingetDatabase()
. This is important because consumers (mostly, schema managers) should handle the situation of "no database selected" (which they currently don't) and raise an error instead of returning an empty list of assets.