Removed Driver::getName() #3553
Merged
+79
−367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method is not used for anything else than skipping tests for specific drivers. Cross-driver portability should be established by drivers, not outside of them based on their name.
jwage
approved these changes
May 24, 2019
morozov
added a commit
to morozov/dbal
that referenced
this pull request
May 31, 2019
Removed Driver::getName()
morozov
added a commit
to morozov/dbal
that referenced
this pull request
May 31, 2019
Removed Driver::getName()
morozov
added a commit
to morozov/dbal
that referenced
this pull request
May 31, 2019
Removed Driver::getName()
morozov
added a commit
to morozov/dbal
that referenced
this pull request
Aug 26, 2019
Removed Driver::getName()
morozov
added a commit
to morozov/dbal
that referenced
this pull request
Aug 27, 2019
Removed Driver::getName()
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method is not used for anything else than skipping tests for specific drivers. Cross-driver portability should be established by drivers, not outside of them based on their name.
This aligns with the earlier removal of
Type::__toString()in #3257.TODO: