Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ExceptionTest::testConnectionExceptionSqLite #3530

Merged
merged 1 commit into from
Apr 23, 2019
Merged

Improve ExceptionTest::testConnectionExceptionSqLite #3530

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 42 additions & 19 deletions tests/Doctrine/Tests/DBAL/Functional/ExceptionTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,13 @@
use Doctrine\DBAL\Schema\Table;
use Doctrine\Tests\DbalFunctionalTestCase;
use Throwable;
use const PHP_OS;
use function array_merge;
use function chmod;
use function defined;
use function exec;
use function file_exists;
use function posix_geteuid;
use function posix_getpwuid;
use function sprintf;
use function sys_get_temp_dir;
use function touch;
Expand Down Expand Up @@ -284,25 +287,28 @@ public function testSyntaxErrorException()
$this->connection->executeQuery($sql);
}

/**
* @dataProvider getSqLiteOpenConnection
*/
public function testConnectionExceptionSqLite($mode, $exceptionClass)
public function testConnectionExceptionSqLite()
{
if ($this->connection->getDatabasePlatform()->getName() !== 'sqlite') {
$this->markTestSkipped('Only fails this way on sqlite');
}

// mode 0 is considered read-only on Windows
$mode = PHP_OS === 'Linux' ? 0444 : 0000;

$filename = sprintf('%s/%s', sys_get_temp_dir(), 'doctrine_failed_connection_' . $mode . '.db');

if (file_exists($filename)) {
chmod($filename, 0200); // make the file writable again, so it can be removed on Windows
unlink($filename);
$this->cleanupReadOnlyFile($filename);
}

touch($filename);
chmod($filename, $mode);

if ($this->isLinuxRoot()) {
exec(sprintf('chattr +i %s', $filename));
}

$params = [
'driver' => 'pdo_sqlite',
'path' => $filename,
Expand All @@ -313,19 +319,21 @@ public function testConnectionExceptionSqLite($mode, $exceptionClass)
$table = $schema->createTable('no_connection');
$table->addColumn('id', 'integer');

$this->expectException($exceptionClass);
foreach ($schema->toSql($conn->getDatabasePlatform()) as $sql) {
$conn->exec($sql);
}
}
$this->expectException(Exception\ReadOnlyException::class);
$this->expectExceptionMessage(<<<EOT
An exception occurred while executing 'CREATE TABLE no_connection (id INTEGER NOT NULL)':

public function getSqLiteOpenConnection()
{
return [
// mode 0 is considered read-only on Windows
[0000, defined('PHP_WINDOWS_VERSION_BUILD') ? Exception\ReadOnlyException::class : Exception\ConnectionException::class],
[0444, Exception\ReadOnlyException::class],
];
SQLSTATE[HY000]: General error: 8 attempt to write a readonly database
EOT
);

try {
foreach ($schema->toSql($conn->getDatabasePlatform()) as $sql) {
$conn->exec($sql);
}
} finally {
$this->cleanupReadOnlyFile($filename);
}
}

/**
Expand Down Expand Up @@ -395,4 +403,19 @@ private function tearDownForeignKeyConstraintViolationExceptionTest()
$schemaManager->dropTable('owning_table');
$schemaManager->dropTable('constraint_error_table');
}

private function isLinuxRoot() : bool
{
return PHP_OS === 'Linux' && posix_getpwuid(posix_geteuid())['name'] === 'root';
}

private function cleanupReadOnlyFile(string $filename) : void
{
if ($this->isLinuxRoot()) {
exec(sprintf('chattr -i %s', $filename));
}

chmod($filename, 0200); // make the file writable again, so it can be removed on Windows
unlink($filename);
}
}