Fix returning the proper last inserted id in MSSQL #3523
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarven
force-pushed
the
3516-invalid-the-last-inserted-id-when-the-table-has-a-trigger-with-an-insert-stmt-in-mssql
branch
from
a10b812 to
2a08876
Compare
sarven
force-pushed
the
3516-invalid-the-last-inserted-id-when-the-table-has-a-trigger-with-an-insert-stmt-in-mssql
branch
from
492f874 to
9bd8e85
Compare
…having to replicate the \PDOStatement interface in ResultStatement
sarven
force-pushed
the
3516-invalid-the-last-inserted-id-when-the-table-has-a-trigger-with-an-insert-stmt-in-mssql
branch
from
456e5a8 to
79b93df
Compare
Ocramius
suggested changes
May 27, 2019
There was a problem hiding this comment.
I'd need @deeky666 to check this patch, since he initially authored #2648 (which was closed due to its high complexity/risk for little gain).
I'd say that also here the same applies: if a prepared statement is causing side-effects through stored procedures and triggers, I'd rather call the schema "foobar'd" and "needs to be fixed there" rather than trying to fix issues on this end.
morozov
force-pushed
the
develop
branch
3 times, most recently
from
10890d6 to
3836750
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I discovered a problem when the table in MSSQL has a trigger with insert statements. Id returned by method lastInsertId is invalid. It isn't id from the table in where we were inserting data, but from the table that trigger was inserting data.
The problem concerns sqlsrv and pdo_sqlsrv extensions. The fix for sqlsrv was quite simple, I only added a few lines of code.
But the fix for pdo_sqlsrv required to rebuild the implementation of Connection and Statement. I made it similar to the sqlsrv implementation.