-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for feferred misspelling in PostgreSqlPlatform::getAdvancedForeignKeyOptionsSQL() #3520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PostgreSqlPlatform::getAdvancedForeignKeyOptionsSQL()
morozov
approved these changes
Apr 17, 2019
## BC BREAK PostgreSqlPlatform ForeignKeyConstraint support for `feferred` misspelling removed | ||
|
||
`PostgreSqlPlatform::getAdvancedForeignKeyOptionsSQL()` had a typo in it in 2.x. Both the option name | ||
`feferred` and `deferred` were supported in `2.x` but the misspelling was removed in 3.x. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's funny.
morozov
pushed a commit
that referenced
this pull request
May 6, 2019
…y-constraints Drop support for feferred misspelling in PostgreSqlPlatform::getAdvancedForeignKeyOptionsSQL()
morozov
pushed a commit
that referenced
this pull request
May 23, 2019
…y-constraints Drop support for feferred misspelling in PostgreSqlPlatform::getAdvancedForeignKeyOptionsSQL()
morozov
pushed a commit
to morozov/dbal
that referenced
this pull request
May 31, 2019
…reign-key-constraints Drop support for feferred misspelling in PostgreSqlPlatform::getAdvancedForeignKeyOptionsSQL()
morozov
pushed a commit
to morozov/dbal
that referenced
this pull request
May 31, 2019
…reign-key-constraints Drop support for feferred misspelling in PostgreSqlPlatform::getAdvancedForeignKeyOptionsSQL()
morozov
pushed a commit
that referenced
this pull request
Jun 13, 2019
…y-constraints Drop support for feferred misspelling in PostgreSqlPlatform::getAdvancedForeignKeyOptionsSQL()
morozov
pushed a commit
that referenced
this pull request
Jun 27, 2019
…y-constraints Drop support for feferred misspelling in PostgreSqlPlatform::getAdvancedForeignKeyOptionsSQL()
morozov
pushed a commit
that referenced
this pull request
Jun 27, 2019
…y-constraints Drop support for feferred misspelling in PostgreSqlPlatform::getAdvancedForeignKeyOptionsSQL()
morozov
pushed a commit
that referenced
this pull request
Jun 27, 2019
…y-constraints Drop support for feferred misspelling in PostgreSqlPlatform::getAdvancedForeignKeyOptionsSQL()
morozov
pushed a commit
to morozov/dbal
that referenced
this pull request
Aug 26, 2019
…reign-key-constraints Drop support for feferred misspelling in PostgreSqlPlatform::getAdvancedForeignKeyOptionsSQL()
morozov
pushed a commit
to morozov/dbal
that referenced
this pull request
Aug 27, 2019
…reign-key-constraints Drop support for feferred misspelling in PostgreSqlPlatform::getAdvancedForeignKeyOptionsSQL()
morozov
pushed a commit
that referenced
this pull request
Nov 2, 2019
…y-constraints Drop support for feferred misspelling in PostgreSqlPlatform::getAdvancedForeignKeyOptionsSQL()
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PostgreSqlPlatform::getAdvancedForeignKeyOptionsSQL()
had a typo in it in 2.x. This PR removes support for option namefeferred
and keepsdeferred
.