Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for feferred misspelling in PostgreSqlPlatform::getAdvancedForeignKeyOptionsSQL() #3520

Merged
merged 1 commit into from
Apr 17, 2019

Conversation

jwage
Copy link
Member

@jwage jwage commented Apr 17, 2019

Q A
Type improvement
BC Break yes
Fixed issues #3218

Summary

PostgreSqlPlatform::getAdvancedForeignKeyOptionsSQL() had a typo in it in 2.x. This PR removes support for option name feferred and keeps deferred.

PostgreSqlPlatform::getAdvancedForeignKeyOptionsSQL()
## BC BREAK PostgreSqlPlatform ForeignKeyConstraint support for `feferred` misspelling removed

`PostgreSqlPlatform::getAdvancedForeignKeyOptionsSQL()` had a typo in it in 2.x. Both the option name
`feferred` and `deferred` were supported in `2.x` but the misspelling was removed in 3.x.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's funny.

@morozov morozov self-assigned this Apr 17, 2019
@jwage jwage merged commit 90495ab into develop Apr 17, 2019
@jwage jwage deleted the drop-misspelling-in-foreign-key-constraints branch April 17, 2019 19:53
@morozov morozov assigned jwage and unassigned morozov Apr 17, 2019
morozov pushed a commit that referenced this pull request May 6, 2019
…y-constraints

Drop support for feferred misspelling in PostgreSqlPlatform::getAdvancedForeignKeyOptionsSQL()
morozov pushed a commit that referenced this pull request May 23, 2019
…y-constraints

Drop support for feferred misspelling in PostgreSqlPlatform::getAdvancedForeignKeyOptionsSQL()
morozov pushed a commit to morozov/dbal that referenced this pull request May 31, 2019
…reign-key-constraints

Drop support for feferred misspelling in PostgreSqlPlatform::getAdvancedForeignKeyOptionsSQL()
morozov pushed a commit to morozov/dbal that referenced this pull request May 31, 2019
…reign-key-constraints

Drop support for feferred misspelling in PostgreSqlPlatform::getAdvancedForeignKeyOptionsSQL()
morozov pushed a commit that referenced this pull request Jun 13, 2019
…y-constraints

Drop support for feferred misspelling in PostgreSqlPlatform::getAdvancedForeignKeyOptionsSQL()
morozov pushed a commit that referenced this pull request Jun 27, 2019
…y-constraints

Drop support for feferred misspelling in PostgreSqlPlatform::getAdvancedForeignKeyOptionsSQL()
morozov pushed a commit that referenced this pull request Jun 27, 2019
…y-constraints

Drop support for feferred misspelling in PostgreSqlPlatform::getAdvancedForeignKeyOptionsSQL()
morozov pushed a commit that referenced this pull request Jun 27, 2019
…y-constraints

Drop support for feferred misspelling in PostgreSqlPlatform::getAdvancedForeignKeyOptionsSQL()
morozov pushed a commit to morozov/dbal that referenced this pull request Aug 26, 2019
…reign-key-constraints

Drop support for feferred misspelling in PostgreSqlPlatform::getAdvancedForeignKeyOptionsSQL()
morozov pushed a commit to morozov/dbal that referenced this pull request Aug 27, 2019
…reign-key-constraints

Drop support for feferred misspelling in PostgreSqlPlatform::getAdvancedForeignKeyOptionsSQL()
morozov pushed a commit that referenced this pull request Nov 2, 2019
…y-constraints

Drop support for feferred misspelling in PostgreSqlPlatform::getAdvancedForeignKeyOptionsSQL()
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants