Remove @deprecated stuff #3518

Majkl578 · 2019-04-15T17:08:00Z

Q	A
Type	improvement
BC Break	yes

Summary

Removes so far @deprecated stuff for DBAL 3.0. Fixes #3508.

Majkl578 · 2019-04-15T17:08:38Z

@morozov There will be rebase conflicts due to changes in Type so we can wait until develop is up-to-date and I'll rebase the PR afterwards.

morozov

Looks good so far. A few notes:

Configuration::setFilterSchemaAssetsExpression() is also deprecated and should be removed.
There are a few cases with trigger_error(/* ... */, E_DEPRECATED).

morozov · 2019-04-16T03:41:59Z

lib/Doctrine/DBAL/SQLParserUtils.php

-    public const NAMED_TOKEN      = '(?<!:):[a-zA-Z_][a-zA-Z0-9_]*';
-    /**#@-*/
+    private const POSITIONAL_TOKEN = '\?';
+    private const NAMED_TOKEN      = '(?<!:):[a-zA-Z_][a-zA-Z0-9_]*';

    // Quote characters within string literals can be preceded by a backslash.
    public const ESCAPED_SINGLE_QUOTED_TEXT   = "(?:'(?:\\\\\\\\)+'|'(?:[^'\\\\]|\\\\'?|'')*')";
    public const ESCAPED_DOUBLE_QUOTED_TEXT   = '(?:"(?:\\\\\\\\)+"|"(?:[^"\\\\]|\\\\"?)*")';
    public const ESCAPED_BACKTICK_QUOTED_TEXT = '(?:`(?:\\\\\\\\)+`|`(?:[^`\\\\]|\\\\`?)*`)';
    private const ESCAPED_BRACKET_QUOTED_TEXT = '(?<!\b(?i:ARRAY))\[(?:[^\]])*\]';


These constants should also be deprecated and made private.

morozov · 2019-04-16T04:07:15Z

Also, SQLSrvStatement::LAST_INSERT_ID_SQL could be deprecated and made private.

Majkl578 · 2019-04-16T18:41:48Z

Rebased.

morozov · 2019-04-16T19:35:35Z

tests/Doctrine/Tests/DBAL/SQLParserUtilsTest.php

-    /**
-     * @dataProvider dataGetPlaceholderPositions
-     */
-    public function testGetPlaceholderPositions($query, $isPositional, $expectedParamPos)


Should this be reworked in two tests, not deleted?

Seems to be testing a deleted method.

Yes, but the method was split apart into two other methods, not just deleted.

Hmm but the test wasn't? That's weird. Ok.

Ah, the methods are private.
How do you suggest to test them? Reflection?

Split into two new tests and two data providers, using reflection - if you have better idea let me know. :)

Hmm but the test wasn't? That's weird. Ok.

I didn't notice it at that time.

[…] if you have better idea let me know. :)

It's good enough to me.

Majkl578 · 2019-05-08T14:50:39Z

Why was this PR closed? @morozov @jwage?

jwage · 2019-05-08T14:59:11Z

Work is being continued here #3538

Majkl578 · 2019-05-08T14:59:57Z

That is not a valid reason to close an open PR that was not inactive - no one even asked me to rebase this PR or anything else. You are basically only stealing my work.

jwage · 2019-05-08T15:03:18Z

@Majkl578 Happy to continue the work in here. Since you closed many other PRs and deleted the branches I assumed you were not interested in continuing the work. Apologies if that assumption was incorrect. Would you like to continue the work here?

Majkl578 · 2019-05-08T15:08:14Z

I closed PRs in other repos because I lost interest in contributing to an organization that treats members like gabrage.
Regarding PRs in DBAL @morozov and me came up with a list of issues to either finish or abandon, those open are active and to be finished either by me, by @morozov or both.

jwage · 2019-05-08T15:09:36Z

Understood. @morozov asked if I could finish #3518 and I obliged. Would you like to finish the pull request here or make the branch open so that we can continue the work?

Majkl578 · 2019-05-08T15:11:49Z

I will do it here but at this moment there are no requested changes here - the PR was simply ready for review/merge (except maybe rebase), not aware of anything needed to finish #3518.

jwage · 2019-05-08T15:12:37Z

Cool. Can you rebase? Then @morozov and I will help get it reviewed and merged.

Majkl578 · 2019-05-08T15:30:16Z

Sure, will do soon.

…Platform::TRIM_* constants

…addNamedForeignKeyConstraint()

…ion(), Configuration::getFilterSchemaAssetsExpression() and Configuration::getFilterSchemaAssetsExpression()

morozov · 2019-05-23T18:51:54Z

Thanks @Majkl578!

Remove @deprecated stuff

Majkl578 added WIP Improvement BC Break labels Apr 15, 2019

Majkl578 added this to the 3.0.0 milestone Apr 15, 2019

Majkl578 requested a review from morozov April 15, 2019 17:08

javiereguiluz mentioned this pull request Apr 15, 2019

Update docs for latest Doctrine removals symfony/symfony-docs#9401

Closed

8 tasks

morozov reviewed Apr 16, 2019

View reviewed changes

morozov force-pushed the develop branch from 09565d5 to 6daf933 Compare April 16, 2019 04:11

Majkl578 force-pushed the drop-deprecated branch from db0b1ff to eecf3b9 Compare April 16, 2019 18:41

Majkl578 force-pushed the drop-deprecated branch from eecf3b9 to d77510d Compare April 16, 2019 18:42

morozov reviewed Apr 16, 2019

View reviewed changes

Majkl578 force-pushed the drop-deprecated branch from d77510d to d983c4f Compare April 16, 2019 20:06

morozov mentioned this pull request May 1, 2019

Improve consistency of exception message formatting. #3536

Merged

1 task

morozov force-pushed the develop branch from e46c09b to 5ee9443 Compare May 6, 2019 04:48

jwage closed this May 8, 2019

jwage mentioned this pull request May 8, 2019

Remove deprecated stuff #3538

Closed

jwage reopened this May 8, 2019

Majkl578 force-pushed the drop-deprecated branch from d983c4f to 673c62c Compare May 19, 2019 16:51

Majkl578 added 9 commits May 23, 2019 11:33

Remove deprecated AbstractPlatform::DATE_INTERVAL_UNIT_* and Abstract…

623ca14

…Platform::TRIM_* constants

Remove deprecated MysqlSessionInit listener

0dbca36

Remove deprecated MysqlPlatform::getCollationFieldDeclaration()

cab0ce4

Remove deprecated AbstractPlatform::getIdentityColumnNullInsertSQL()

9d652f9

Remove deprecated Table::addUnnamedForeignKeyConstraint() and Table::…

a28941b

…addNamedForeignKeyConstraint()

SQLParserUtils::*_TOKEN constants made private

9539988

Remove deprecated SQLParserUtils::getPlaceholderPositions()

4924169

Remove deprecated Table::renameColumn()

d370eeb

Remove deprecated AbstractSchemaManager::getFilterSchemaAssetsExpress…

1993fc2

…ion(), Configuration::getFilterSchemaAssetsExpression() and Configuration::getFilterSchemaAssetsExpression()

morozov force-pushed the drop-deprecated branch from 673c62c to 1993fc2 Compare May 23, 2019 18:38

morozov removed the WIP label May 23, 2019

morozov self-assigned this May 23, 2019

morozov merged commit d1c6699 into doctrine:develop May 23, 2019

morozov mentioned this pull request May 23, 2019

Remove all deprecated functionality from 3.0 #3508

Closed

Majkl578 deleted the drop-deprecated branch May 23, 2019 19:04

morozov added a commit to morozov/dbal that referenced this pull request May 31, 2019

Merge pull request doctrine#3518 from Majkl578/drop-deprecated

14c20e4

Remove @deprecated stuff

morozov added a commit to morozov/dbal that referenced this pull request May 31, 2019

Merge pull request doctrine#3518 from Majkl578/drop-deprecated

455db49

Remove @deprecated stuff

morozov added a commit to morozov/dbal that referenced this pull request May 31, 2019

Merge pull request doctrine#3518 from Majkl578/drop-deprecated

890fe34

Remove @deprecated stuff

morozov added a commit that referenced this pull request Jun 13, 2019

Merge pull request #3518 from Majkl578/drop-deprecated

2117e31

Remove @deprecated stuff

morozov added a commit that referenced this pull request Jun 27, 2019

Merge pull request #3518 from Majkl578/drop-deprecated

b5e3009

Remove @deprecated stuff

morozov added a commit that referenced this pull request Jun 27, 2019

Merge pull request #3518 from Majkl578/drop-deprecated

db888c9

Remove @deprecated stuff

morozov added a commit that referenced this pull request Jun 27, 2019

Merge pull request #3518 from Majkl578/drop-deprecated

81b244f

Remove @deprecated stuff

morozov added a commit to morozov/dbal that referenced this pull request Aug 26, 2019

Merge pull request doctrine#3518 from Majkl578/drop-deprecated

7b89214

Remove @deprecated stuff

morozov added a commit to morozov/dbal that referenced this pull request Aug 27, 2019

Merge pull request doctrine#3518 from Majkl578/drop-deprecated

437e920

Remove @deprecated stuff

morozov added a commit that referenced this pull request Nov 2, 2019

Merge pull request #3518 from Majkl578/drop-deprecated

a4158b5

Remove @deprecated stuff

morozov mentioned this pull request Jun 17, 2020

Backport removal of deprecated APIs from develop #4082

Merged

2 tasks

morozov modified the milestones: 4.0.0, 3.0.0 Jun 17, 2020

github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove @deprecated stuff #3518

Remove @deprecated stuff #3518

Majkl578 commented Apr 15, 2019 •

edited by morozov

Loading

Majkl578 commented Apr 15, 2019 •

edited

Loading

morozov left a comment

morozov Apr 16, 2019

morozov commented Apr 16, 2019

Majkl578 commented Apr 16, 2019

morozov Apr 16, 2019

Majkl578 Apr 16, 2019

morozov Apr 16, 2019

Majkl578 Apr 16, 2019

Majkl578 Apr 16, 2019

Majkl578 Apr 16, 2019

morozov Apr 16, 2019

Majkl578 commented May 8, 2019

jwage commented May 8, 2019

Majkl578 commented May 8, 2019

jwage commented May 8, 2019

Majkl578 commented May 8, 2019

jwage commented May 8, 2019

Majkl578 commented May 8, 2019

jwage commented May 8, 2019

Majkl578 commented May 8, 2019

morozov commented May 23, 2019

Remove @​deprecated stuff #3518

Remove @​deprecated stuff #3518

Conversation

Majkl578 commented Apr 15, 2019 • edited by morozov Loading

Summary

Majkl578 commented Apr 15, 2019 • edited Loading

morozov left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

morozov commented Apr 16, 2019

Majkl578 commented Apr 16, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Majkl578 commented May 8, 2019

jwage commented May 8, 2019

Majkl578 commented May 8, 2019

jwage commented May 8, 2019

Majkl578 commented May 8, 2019

jwage commented May 8, 2019

Majkl578 commented May 8, 2019

jwage commented May 8, 2019

Majkl578 commented May 8, 2019

morozov commented May 23, 2019

Remove @deprecated stuff #3518

Remove @deprecated stuff #3518

Majkl578 commented Apr 15, 2019 •

edited by morozov

Loading

Majkl578 commented Apr 15, 2019 •

edited

Loading