Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed DB2SchemaManager::_getPortableForeignKeyRuleDef() #3502

Merged

Conversation

morozov
Copy link
Member

@morozov morozov commented Mar 30, 2019

Q A
Type improvement
BC Break yes

The method is unused since #447 (v2.5.0-BETA2). Its logic is still implemented in DB2Platform::getListTableForeignKeysSQL() and is covered by SchemaManagerFunctionalTestCase::testListForeignKeys().

@Majkl578 Majkl578 merged commit 347d2fe into doctrine:develop Apr 3, 2019
@Majkl578 Majkl578 added this to the 3.0.0 milestone Apr 3, 2019
@Majkl578 Majkl578 self-assigned this Apr 3, 2019
@morozov morozov deleted the db2-get-portable-foreign-key-rule-def branch April 3, 2019 23:28
morozov pushed a commit that referenced this pull request Apr 16, 2019
…le-def

Removed DB2SchemaManager::_getPortableForeignKeyRuleDef()
morozov pushed a commit that referenced this pull request May 6, 2019
…le-def

Removed DB2SchemaManager::_getPortableForeignKeyRuleDef()
morozov pushed a commit that referenced this pull request May 23, 2019
…le-def

Removed DB2SchemaManager::_getPortableForeignKeyRuleDef()
morozov pushed a commit to morozov/dbal that referenced this pull request May 31, 2019
…n-key-rule-def

Removed DB2SchemaManager::_getPortableForeignKeyRuleDef()
morozov pushed a commit that referenced this pull request Jun 13, 2019
…le-def

Removed DB2SchemaManager::_getPortableForeignKeyRuleDef()
morozov pushed a commit that referenced this pull request Jun 27, 2019
…le-def

Removed DB2SchemaManager::_getPortableForeignKeyRuleDef()
morozov pushed a commit that referenced this pull request Jun 27, 2019
…le-def

Removed DB2SchemaManager::_getPortableForeignKeyRuleDef()
morozov pushed a commit that referenced this pull request Jun 27, 2019
…le-def

Removed DB2SchemaManager::_getPortableForeignKeyRuleDef()
morozov pushed a commit to morozov/dbal that referenced this pull request Aug 26, 2019
…n-key-rule-def

Removed DB2SchemaManager::_getPortableForeignKeyRuleDef()
morozov pushed a commit that referenced this pull request Nov 2, 2019
…le-def

Removed DB2SchemaManager::_getPortableForeignKeyRuleDef()
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants