Converted Connection and Statement methods which returned false in case of a failure into void #3486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
morozov
commented
Mar 15, 2019
morozov
commented
| Q | A |
|---|---|
| Type | improvement |
| BC Break | yes |
…se of a failure into void
Majkl578
reviewed
Mar 16, 2019
Ocramius
approved these changes
Mar 16, 2019
| } | ||
|
|
||
| return true; | ||
| $eventArgs = new ConnectionEventArgs($this); |
There was a problem hiding this comment.
It was like this prior to the change and only got changed because of EarlyExitNotUsed which often makes more harm than good if enforced (e.g. slevomat/coding-standard#371).
morozov
added a commit
that referenced
this pull request
Mar 18, 2019
Converted Connection and Statement methods which returned false in case of a failure into void
morozov
added a commit
that referenced
this pull request
Apr 16, 2019
Converted Connection and Statement methods which returned false in case of a failure into void
morozov
added a commit
that referenced
this pull request
May 6, 2019
Converted Connection and Statement methods which returned false in case of a failure into void
morozov
added a commit
that referenced
this pull request
May 23, 2019
Converted Connection and Statement methods which returned false in case of a failure into void
morozov
added a commit
to morozov/dbal
that referenced
this pull request
May 31, 2019
Converted Connection and Statement methods which returned false in case of a failure into void
morozov
added a commit
that referenced
this pull request
Jun 13, 2019
Converted Connection and Statement methods which returned false in case of a failure into void
morozov
added a commit
that referenced
this pull request
Jun 27, 2019
Converted Connection and Statement methods which returned false in case of a failure into void
morozov
added a commit
that referenced
this pull request
Jun 27, 2019
Converted Connection and Statement methods which returned false in case of a failure into void
morozov
added a commit
that referenced
this pull request
Jun 27, 2019
Converted Connection and Statement methods which returned false in case of a failure into void
morozov
added a commit
to morozov/dbal
that referenced
this pull request
Aug 26, 2019
Converted Connection and Statement methods which returned false in case of a failure into void
morozov
added a commit
that referenced
this pull request
Nov 2, 2019
Converted Connection and Statement methods which returned false in case of a failure into void
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.