Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction-related Statement methods return void #3480

Merged
merged 2 commits into from
Mar 13, 2019

Conversation

morozov
Copy link
Member

@morozov morozov commented Mar 13, 2019

Q A
Type improvement
BC Break yes

As was suggested in #3348 (comment), I'm beginning to split the pull request into smaller parts starting with breaking changes.

@morozov morozov requested review from Majkl578 and Ocramius March 13, 2019 07:20
Copy link
Contributor

@Majkl578 Majkl578 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Ocramius Ocramius self-assigned this Mar 13, 2019
@Ocramius Ocramius merged commit 86615fa into doctrine:develop Mar 13, 2019
@morozov morozov deleted the transaction-void branch March 13, 2019 21:05
morozov pushed a commit that referenced this pull request Mar 15, 2019
Transaction-related Statement methods return void
morozov pushed a commit that referenced this pull request Mar 15, 2019
Transaction-related Statement methods return void
morozov pushed a commit that referenced this pull request Mar 18, 2019
Transaction-related Statement methods return void
morozov pushed a commit that referenced this pull request Apr 16, 2019
Transaction-related Statement methods return void
morozov pushed a commit that referenced this pull request May 6, 2019
Transaction-related Statement methods return void
morozov pushed a commit that referenced this pull request May 23, 2019
Transaction-related Statement methods return void
morozov pushed a commit to morozov/dbal that referenced this pull request May 31, 2019
Transaction-related Statement methods return void
morozov pushed a commit that referenced this pull request Jun 13, 2019
Transaction-related Statement methods return void
@morozov morozov mentioned this pull request Jun 25, 2019
morozov pushed a commit that referenced this pull request Jun 27, 2019
Transaction-related Statement methods return void
morozov pushed a commit that referenced this pull request Jun 27, 2019
Transaction-related Statement methods return void
morozov pushed a commit that referenced this pull request Jun 27, 2019
Transaction-related Statement methods return void
morozov pushed a commit to morozov/dbal that referenced this pull request Aug 26, 2019
Transaction-related Statement methods return void
morozov pushed a commit that referenced this pull request Nov 2, 2019
Transaction-related Statement methods return void
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants