Fixed QueryBuilder type hints #3439
Conversation
|
@petrnemec thank you for the patch. I'm currently working on making the codebase compliant with PHPStan Level 6 and 7 requirements (see the previous changes in #3435 and #3436). Most likely, this will be taken care of by the upcoming changes. I'm not going to accept these changes right now since they are not enforced by raising PHPStan level requirement. |
| @@ -107,14 +107,14 @@ class QueryBuilder | |||
| /** | |||
| * The index of the first result to retrieve. | |||
| * | |||
| * @var int | |||
| * @var int|null | |||
There was a problem hiding this comment.
It's not supposed to be nullable. The "non specified" first result is the same as 0.
There was a problem hiding this comment.
Default value of property this is null, init value is not set in constructor, so it should be marked as nullable.
There was a problem hiding this comment.
The default value should be 0, not null unless it breaks some existing API contract.
Summary
Fixed type hints for
$firstResultand$maxResultsproperties