Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect exception thrown from SQLAnywhere16Platform #3178

Merged
merged 1 commit into from
Jun 7, 2018
Merged

Fix incorrect exception thrown from SQLAnywhere16Platform #3178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions UPGRADE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
# Upgrade to 2.8

## Corrected exception thrown by ``Doctrine\DBAL\Platforms\SQLAnywhere16Platform::getAdvancedIndexOptionsSQL()``

This method now throws SPL ``UnexpectedValueException`` instead of accidentally throwing ``Doctrine\Common\Proxy\Exception\UnexpectedValueException``.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that a couple of other drivers already throw SPL UnexpectedValueException however it's not reflected anywhere in their API documentation. Meaning that the caller doesn't know it can expect this kind of exception to be thrown.

I get the idea behind the change but maybe instead of just getting rid of an incorrect exception, we should introduce some sort of DBAL exception which the caller could catch together with other exceptions which a driver can throw?

Or just throw a generic DBALException?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth doing given that we're reworking exceptions in #3131 + even further?
We can leave it as is but we won't be able to get rid of doctrine/common in 2.8 then.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm all in favor of getting rid of doctrine/common, I'm just saying we need to replace it with a DBAL exception rather than SPL one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is currently other 35 occurences where platforms throw SPL exception directly.
I am still not sure whether it's worth changing it to DBALException solely for 2.8 (thus also breaking UnexpectedValueException inheritance assumption). I would rather leave this for 3.0 and fix it globally there. :/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it’ 35 of them un total, I agree. And aso agree with the inheritance argument.


# Upgrade to 2.7

## Doctrine\DBAL\Platforms\AbstractPlatform::DATE_INTERVAL_UNIT_* constants deprecated
Expand Down
2 changes: 1 addition & 1 deletion lib/Doctrine/DBAL/Platforms/SQLAnywhere16Platform.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@

namespace Doctrine\DBAL\Platforms;

use Doctrine\Common\Proxy\Exception\UnexpectedValueException;
use Doctrine\DBAL\Schema\Index;
use UnexpectedValueException;

/**
* The SQLAnywhere16Platform provides the behavior, features and SQL dialect of the
Expand Down