Fix closing statement cursor on pdo_sqlsrv if not executed yet #2651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Btw there are already tests that reveal this issue: |
Ocramius
approved these changes
Feb 9, 2017
Ocramius
added a commit
that referenced
this pull request
Feb 9, 2017
…do-sqlsrv' into 2.5 Backport #2651 to 2.5.x
|
Backported to |
|
Should be fixed by microsoft/msphpsql#281. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pdo_sqlsrvdoes not strictly stick to the PDO interface, yet and throws and exception when trying to close a statement cursor if it has not been execute yet:A patch is in the works, though: microsoft/msphpsql#267
Despite that, we should try to make the behaviour consistent for all kinds of PDO drivers, even those that we might not support in the core. Therefore silencing execptions in
closeCursor().