Added support for column collation #245
Conversation
|
Hello, thank you for positing this Pull Request. I have automatically opened an issue on our Jira Bug Tracker for you with the details of this Pull-Request. See the Link: |
| @@ -303,6 +312,11 @@ public function getDefault() | |||
| return $this->_default; | |||
| } | |||
|
|
|||
| public function getCollation() | |||
|
Patch seems good. |
|
Please dont add a new method getCollation()/setcollation() but use the options instead. Collatoin is sometihng database specific. |
|
@beberlei, @adrienbrault Yours opinion? |
| * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, | ||
| * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT | ||
| * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, | ||
| * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY |
There was a problem hiding this comment.
Wrong indentation of the license header
|
ping |
|
Any chance this is going to make it into 2.4? |
|
@caponica hardly - we're in RC: only bugfixes I suppose... |
|
Wasn't sure where we're at with 2.4. What more needs to be done to this one to make it ready for acceptance? (i.e. if I can help just let me know how!) |
|
Is there a state on this PR when it is going to be released? |
|
Not that I've heard of, but lets hope it's soon! |
| public function postConnect(ConnectionEventArgs $args) | ||
| { | ||
| $connection = $args->getConnection(); | ||
| $result = $connection->exec('SELECT VERSION()'); |
|
What's the status of this PR? |
| if ($column1->getUnsigned() != $column2->getUnsigned()) { | ||
| $changedProperties[] = 'unsigned'; | ||
| foreach (array('type', 'notnull', 'default', 'unsigned', 'autoincrement') as $property) { | ||
| if ($properties1[$property] !== $properties2[$property]) { |
There was a problem hiding this comment.
The strict comparison here changes the behaviour of the comparator. I don't know what side effects this creates. I would leave the loose comparison here. One example: You create a column with default value 0 (integer). Afterwards you reverse engineer the column from database and eventually it returns 0 as string. Then using strict comparison will generate unecessary changes.
|
@kimhemsoe I guess Drizzle also supports column collations. Can you maybe investigate and add support for it? This would make the support complete over all platforms. |
|
@deeky666 Isn't it better to get this released with support for some platforms then add others later as enhancements? I know it's tantalising to be close to complete support, but I don't think it's a requirement. |
| /** | ||
| * PostgreSQL 9.1 reserved keywords list. | ||
| * | ||
| * @author Martin HasOoň <[email protected]> |
There was a problem hiding this comment.
There something wrong here with your name ;) Awesome work on the keywords btw. You read my thoughts :)
|
@beberlei @guilhermeblanco @Ocramius The oldest PR begs you to merge :) |
Added support for column collation
|
Late to this, just wanted to say thanks for getting this in! |
No description provided.