Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added simple_array type #143

Merged
merged 3 commits into from
May 27, 2012
Merged

Conversation

schmittjoh
Copy link
Member

No description provided.

@travisbot
Copy link

This pull request fails (merged 44cd77f into fc3ead2).

@stof
Copy link
Member

stof commented May 7, 2012

This type should be registered as a commented type to avoid weird updates (as the field would be detected as Text otherwise when inspecting the DB)

@schmittjoh
Copy link
Member Author

Not sure I understand what you mean.

@schmittjoh
Copy link
Member Author

This seems like an architectural problem, or how would a custom type register itself a such a type?

@stof
Copy link
Member

stof commented May 7, 2012

@schmittjoh custom types can register themselves as commented types (there is another method for this in the platform), and DoctrineBundle marks custom types as commented by default now (not in 2.0).
And the architecture is indeed not optimal (you have to register types twice: once in the Type class and once in the platform). This is on @beberlei's todo-list AFAIK

@stof
Copy link
Member

stof commented May 20, 2012

@schmittjoh you should update the PR to register the type as commented one.

@beberlei
Copy link
Member

@schmittjoh in AbstractPlatform#initializeCommentedDoctrineTypes()

@travisbot
Copy link

This pull request fails (merged 2d183ac into fc3ead2).

@schmittjoh
Copy link
Member Author

@beberlei, updated

I've also added a JsonArrayType which I found quite useful in practice.

@travisbot
Copy link

This pull request fails (merged 1760be6 into fc3ead2).

@beberlei
Copy link
Member

Why not just JSON? Since it can be an json array or object?

@schmittjoh
Copy link
Member Author

array refers to the PHP type which is converted to JSON, i.e. we are not creating stdClass objects.

I think it makes sense, no?

@beberlei
Copy link
Member

Ah, yes, makes sense.

beberlei added a commit that referenced this pull request May 27, 2012
@beberlei beberlei merged commit e537745 into doctrine:master May 27, 2012
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants