-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added simple_array type #143
Conversation
This type should be registered as a commented type to avoid weird updates (as the field would be detected as Text otherwise when inspecting the DB) |
Not sure I understand what you mean. |
This seems like an architectural problem, or how would a custom type register itself a such a type? |
@schmittjoh custom types can register themselves as commented types (there is another method for this in the platform), and DoctrineBundle marks custom types as commented by default now (not in 2.0). |
@schmittjoh you should update the PR to register the type as commented one. |
@schmittjoh in AbstractPlatform#initializeCommentedDoctrineTypes() |
@beberlei, updated I've also added a JsonArrayType which I found quite useful in practice. |
Why not just JSON? Since it can be an json array or object? |
array refers to the PHP type which is converted to JSON, i.e. we are not creating stdClass objects. I think it makes sense, no? |
Ah, yes, makes sense. |
No description provided.