Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompositeExpression is mutable #3844

Closed
morozov opened this issue Jan 23, 2020 · 4 comments
Closed

CompositeExpression is mutable #3844

morozov opened this issue Jan 23, 2020 · 4 comments

Comments

@morozov
Copy link
Member

morozov commented Jan 23, 2020

Q A
BC Break no
Version 2.10.1

If a composite expression is used in different parts of the same query or in different queries, its implicit mutation by the QueryBuilder::(and|or)(Where|Having)() methods in one place will affect the other places as well.

Before:

$expr->add('u.group_id = 2');

After:

$expr = $expr->with('u.group_id = 2');
@BenMorel
Copy link
Contributor

Fixed in #3858.

@BenMorel
Copy link
Contributor

@morozov Is there anything preventing this issue from being closed?

@morozov
Copy link
Member Author

morozov commented Jan 31, 2020

I usually rely on GitHub to close issues automatically.

@morozov morozov closed this as completed Jan 31, 2020
@morozov morozov added this to the 4.0.0 milestone Mar 18, 2020
@morozov morozov self-assigned this Mar 18, 2020
beberlei added a commit to beberlei/dbal that referenced this issue Mar 7, 2021
beberlei added a commit to beberlei/dbal that referenced this issue Mar 7, 2021
beberlei added a commit to beberlei/dbal that referenced this issue Mar 11, 2021
beberlei added a commit to beberlei/dbal that referenced this issue Mar 11, 2021
beberlei added a commit to beberlei/dbal that referenced this issue Mar 11, 2021
beberlei added a commit to beberlei/dbal that referenced this issue Mar 22, 2021
beberlei added a commit to beberlei/dbal that referenced this issue Mar 27, 2021
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants