Remove usesSequenceEmulatedIdentityColumns()

doctrine · Jul 16, 2022 · f82df77 · f82df77
1 parent 0a1be75
commit f82df77
Show file tree

Hide file tree

Showing 8 changed files with 2 additions and 72 deletions.
diff --git a/UPGRADE.md b/UPGRADE.md
@@ -10,7 +10,8 @@ awareness about deprecated code.
 
 ## BC BREAK: removed `AbstractPlatform` methods.
 
-1. `getIdentitySequenceName()`.
+1. `getIdentitySequenceName()`,
+2. `usesSequenceEmulatedIdentityColumns()`.
 
 ## BC BREAK: removed support for the `NULL` value of schema asset filter.
 

diff --git a/psalm.xml.dist b/psalm.xml.dist
@@ -49,10 +49,7 @@
                 -->
                 <referencedMethod name="Doctrine\DBAL\Platforms\AbstractPlatform::getDefaultSchemaName"/>
                 <referencedMethod name="Doctrine\DBAL\Platforms\AbstractPlatform::supportsCreateDropDatabase"/>
-                <referencedMethod name="Doctrine\DBAL\Platforms\AbstractPlatform::usesSequenceEmulatedIdentityColumns"/>
                 <referencedMethod name="Doctrine\DBAL\Platforms\DB2Platform::supportsCreateDropDatabase"/>
-                <referencedMethod name="Doctrine\DBAL\Platforms\OraclePlatform::usesSequenceEmulatedIdentityColumns"/>
-                <referencedMethod name="Doctrine\DBAL\Platforms\PostgreSQLPlatform::usesSequenceEmulatedIdentityColumns"/>
             </errorLevel>
         </DeprecatedMethod>
         <DocblockTypeContradiction>

diff --git a/src/Platforms/AbstractPlatform.php b/src/Platforms/AbstractPlatform.php
@@ -37,7 +37,6 @@
 use Doctrine\DBAL\Types;
 use Doctrine\DBAL\Types\Exception\TypeNotFound;
 use Doctrine\DBAL\Types\Type;
-use Doctrine\Deprecations\Deprecation;
 use InvalidArgumentException;
 use UnexpectedValueException;
 
@@ -2183,27 +2182,6 @@ public function supportsIdentityColumns(): bool
         return false;
     }
 
-    /**
-     * Whether the platform emulates identity columns through sequences.
-     *
-     * Some platforms that do not support identity columns natively
-     * but support sequences can emulate identity columns by using
-     * sequences.
-     *
-     * @deprecated
-     */
-    public function usesSequenceEmulatedIdentityColumns(): bool
-    {
-        Deprecation::trigger(
-            'doctrine/dbal',
-            'https://github.com/doctrine/dbal/pull/5513',
-            '%s is deprecated.',
-            __METHOD__
-        );
-
-        return false;
-    }
-
     /**
      * Whether the platform supports partial indexes.
      */

diff --git a/src/Platforms/OraclePlatform.php b/src/Platforms/OraclePlatform.php
@@ -16,7 +16,6 @@
 use Doctrine\DBAL\Schema\TableDiff;
 use Doctrine\DBAL\TransactionIsolationLevel;
 use Doctrine\DBAL\Types\BinaryType;
-use Doctrine\Deprecations\Deprecation;
 use InvalidArgumentException;
 
 use function array_merge;
@@ -708,21 +707,6 @@ protected function getRenameIndexSQL(string $oldIndexName, Index $index, string
         return ['ALTER INDEX ' . $oldIndexName . ' RENAME TO ' . $index->getQuotedName($this)];
     }
 
-    /**
-     * @deprecated
-     */
-    public function usesSequenceEmulatedIdentityColumns(): bool
-    {
-        Deprecation::trigger(
-            'doctrine/dbal',
-            'https://github.com/doctrine/dbal/pull/5513',
-            '%s is deprecated.',
-            __METHOD__
-        );
-
-        return true;
-    }
-
     protected function getIdentitySequenceName(string $tableName): string
     {
         $table = new Identifier($tableName);

diff --git a/src/Platforms/PostgreSQLPlatform.php b/src/Platforms/PostgreSQLPlatform.php
@@ -150,21 +150,6 @@ public function supportsPartialIndexes(): bool
         return true;
     }
 
-    /**
-     * @deprecated
-     */
-    public function usesSequenceEmulatedIdentityColumns(): bool
-    {
-        Deprecation::trigger(
-            'doctrine/dbal',
-            'https://github.com/doctrine/dbal/pull/5513',
-            '%s is deprecated.',
-            __METHOD__
-        );
-
-        return true;
-    }
-
     public function supportsCommentOnStatement(): bool
     {
         return true;

diff --git a/tests/Platforms/AbstractPlatformTestCase.php b/tests/Platforms/AbstractPlatformTestCase.php
@@ -692,11 +692,6 @@ public function testAlterTableChangeQuotedColumn(): void
         );
     }
 
-    public function testUsesSequenceEmulatedIdentityColumns(): void
-    {
-        self::assertFalse($this->platform->usesSequenceEmulatedIdentityColumns());
-    }
-
     public function testGetFixedLengthStringTypeDeclarationSQLNoLength(): void
     {
         self::assertSame(

diff --git a/tests/Platforms/OraclePlatformTest.php b/tests/Platforms/OraclePlatformTest.php
@@ -492,11 +492,6 @@ public function testDoesNotPropagateUnnecessaryTableAlterationOnBinaryType(): vo
         );
     }
 
-    public function testUsesSequenceEmulatedIdentityColumns(): void
-    {
-        self::assertTrue($this->platform->usesSequenceEmulatedIdentityColumns());
-    }
-
     /**
      * @dataProvider dataCreateSequenceWithCache
      */

diff --git a/tests/Platforms/PostgreSQLPlatformTest.php b/tests/Platforms/PostgreSQLPlatformTest.php
@@ -569,11 +569,6 @@ public function testDroppingConstraintsBeforeColumns(): void
         self::assertEquals($expectedSql, $sql);
     }
 
-    public function testUsesSequenceEmulatedIdentityColumns(): void
-    {
-        self::assertTrue($this->platform->usesSequenceEmulatedIdentityColumns());
-    }
-
     /**
      * @dataProvider dataCreateSequenceWithCache
      */
-Original file line number
+Diff line change
@@ Expand Up @@
             );
         }
-        public function testUsesSequenceEmulatedIdentityColumns(): void
-        {
-            self::assertTrue($this->platform->usesSequenceEmulatedIdentityColumns());
-        }
         /**
          * @dataProvider dataCreateSequenceWithCache
          */
@@ Expand Down @@