Merge pull request #3667 from morozov/phpstan-fix-backport

Phpstan fix backport
doctrine · Aug 29, 2019 · d9b377c · d9b377c
2 parents 461d424 + 6a2bec0
commit d9b377c
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/phpcs.xml.dist b/phpcs.xml.dist
@@ -77,5 +77,6 @@
     <rule ref="SlevomatCodingStandard.TypeHints.TypeHintDeclaration.IncorrectReturnTypeHint">
         <exclude-pattern>lib/Doctrine/DBAL/Types/ArrayType.php</exclude-pattern>
         <exclude-pattern>lib/Doctrine/DBAL/Types/ObjectType.php</exclude-pattern>
+        <exclude-pattern>tests/Doctrine/Tests/DBAL/Driver/Mysqli/MysqliConnectionTest.php</exclude-pattern>
     </rule>
 </ruleset>
diff --git a/tests/Doctrine/Tests/DBAL/Driver/Mysqli/MysqliConnectionTest.php b/tests/Doctrine/Tests/DBAL/Driver/Mysqli/MysqliConnectionTest.php
@@ -44,7 +44,7 @@ public function testDoesNotRequireQueryForServerVersion() : void
 
     public function testRestoresErrorHandlerOnException() : void
     {
-        $handler         = static function () : void {
+        $handler         = static function () : bool {
             self::fail('Never expected this to be called');
         };
         $default_handler = set_error_handler($handler);

diff --git a/tests/Doctrine/Tests/DBAL/Functional/ExceptionTest.php b/tests/Doctrine/Tests/DBAL/Functional/ExceptionTest.php
@@ -296,7 +296,7 @@ public function testSyntaxErrorException() : void
 
     public function testConnectionExceptionSqLite() : void
     {
-        if ($this->connection instanceof SqlitePlatform) {
+        if ($this->connection->getDatabasePlatform() instanceof SqlitePlatform) {
             $this->markTestSkipped('Only fails this way on sqlite');
         }