Skip to content

Commit

Permalink
Merge pull request #4110 from morozov/convert-positional-placeholders…
Browse files Browse the repository at this point in the history
…-internal

Mark non-interface OCI8 driver methods internal
  • Loading branch information
greg0ire authored Jun 26, 2020
2 parents 0743e04 + a35819d commit d7b24f1
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 0 deletions.
7 changes: 7 additions & 0 deletions UPGRADE.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
# Upgrade to 2.11

## Non-interface driver methods have been marked internal

The non-interface methods of driver-level classes have been marked internal:

- `OCI8Connection::getExecuteMode()`
- `OCI8Statement::convertPositionalToNamedPlaceholders()`

## Inconsistently and ambiguously named driver-level classes are deprecated

The following classes under the `Driver` namespace have been deprecated in favor of their consistently named counterparts:
Expand Down
2 changes: 2 additions & 0 deletions lib/Doctrine/DBAL/Driver/OCI8/OCI8Connection.php
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,8 @@ public function lastInsertId($name = null)
/**
* Returns the current execution mode.
*
* @internal
*
* @return int
*/
public function getExecuteMode()
Expand Down
2 changes: 2 additions & 0 deletions lib/Doctrine/DBAL/Driver/OCI8/OCI8Statement.php
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,8 @@ public function __construct($dbh, $query, OCI8Connection $conn)
* Question marks inside literal strings are therefore handled correctly by this method.
* This comes at a cost, the whole sql statement has to be looped over.
*
* @internal
*
* @param string $statement The SQL statement to convert.
*
* @return mixed[] [0] => the statement value (string), [1] => the paramMap value (array).
Expand Down

0 comments on commit d7b24f1

Please sign in to comment.