Merge pull request #5393 from morozov/remove-sqlite-string-length

Remove hard-coded string column length
doctrine · May 14, 2022 · d40bde4 · d40bde4
2 parents e8ed43b + 0d1e885
commit d40bde4
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 4 deletions.
diff --git a/src/Platforms/SqlitePlatform.php b/src/Platforms/SqlitePlatform.php
@@ -848,9 +848,6 @@ private function getSimpleAlterTableSQL(TableDiff $diff): array|false
             }
 
             $definition['name'] = $column->getQuotedName($this);
-            if ($type instanceof Types\StringType && $definition['length'] === null) {
-                $definition['length'] = 255;
-            }
 
             $sql[] = 'ALTER TABLE ' . $table->getQuotedName($this) . ' ADD COLUMN '
                 . $this->getColumnDeclarationSQL($definition['name'], $definition);

diff --git a/tests/Platforms/SqlitePlatformTest.php b/tests/Platforms/SqlitePlatformTest.php
@@ -309,7 +309,7 @@ public function testAlterTableAddColumns(): void
         ]);
 
         $expected = [
-            'ALTER TABLE user ADD COLUMN foo VARCHAR(255) NOT NULL',
+            'ALTER TABLE user ADD COLUMN foo VARCHAR NOT NULL',
             'ALTER TABLE user ADD COLUMN count INTEGER DEFAULT 1',
         ];