Coding Style

lib/Doctrine/DBAL/Platforms/AbstractPlatform.php

@@ -1459,7 +1459,7 @@ public function getDropTableSQL($table)
             $table = $table->getQuotedName($this);
         }
 
-        if (!is_string($table)) {
+        if (! is_string($table)) {
             throw new \InvalidArgumentException('getDropTableSQL() expects $table parameter to be string or \Doctrine\DBAL\Schema\Table.');
         }
 
@@ -2467,25 +2467,25 @@ public function getCustomTypeDeclarationSQL(array $columnDef)
      * Obtains DBMS specific SQL code portion needed to set an index
      * declaration to be used in statements like CREATE TABLE.
      *
-     * @param array|Index $columnsOrIndex
+     * @param mixed[]|Index $columnsOrIndex
      *
      * @return string
      */
-    public function getIndexFieldDeclarationListSQL($columnsOrIndex)
+    public function getIndexFieldDeclarationListSQL($columnsOrIndex) : string
     {
         if ($columnsOrIndex instanceof Index) {
             return implode(', ', $columnsOrIndex->getQuotedColumns($this));
         }
 
-        if (!is_array($columnsOrIndex)) {
+        if (! is_array($columnsOrIndex)) {
             throw new \InvalidArgumentException('Fields argument should be an Index or an array.');
         }
 
         $ret = [];
 
-        foreach ($columnsOrIndex as $field => $definition) {
+        foreach ($columnsOrIndex as $column => $definition) {
             if (is_array($definition)) {
-                $ret[] = $field;
+                $ret[] = $column;
             } else {
                 $ret[] = $definition;
             }

lib/Doctrine/DBAL/Platforms/MySqlPlatform.php

@@ -1159,9 +1159,9 @@ public function supportsColumnLengthIndexes()
     /**
      * {@inheritdoc}
      */
-    public function getIndexFieldDeclarationListSQL($columnsOrIndex)
+    public function getIndexFieldDeclarationListSQL($columnsOrIndex) : string
     {
-        if (!($columnsOrIndex instanceof Index)) {
+        if (! ($columnsOrIndex instanceof Index)) {
             return parent::getIndexFieldDeclarationListSQL($columnsOrIndex);
         }
 
@@ -1170,9 +1170,9 @@ public function getIndexFieldDeclarationListSQL($columnsOrIndex)
         $ret = [];
 
         foreach ($columnsOrIndex->getQuotedColumns($this) as $quotedColumn) {
-            $length = array_shift($subParts);
+            $length = \array_shift($subParts);
 
-            if (null !== $length) {
+            if ($length !== null) {
                 $quotedColumn .= '(' . $length . ')';
             }
 

lib/Doctrine/DBAL/Schema/AbstractSchemaManager.php

@@ -886,7 +886,7 @@ protected function _getPortableTableIndexesList($tableIndexRows, $tableName=null
                 ];
             }
 
-            $result[$keyName]['columns'][] = $tableIndex['column_name'];
+            $result[$keyName]['columns'][]            = $tableIndex['column_name'];
             $result[$keyName]['options']['lengths'][] = $tableIndex['sub_part'] ?? null;
         }