Merge pull request #5432 from morozov/deprecate-remove-namespaced-assets

Deprecate removal of namespaced assets from schema

UPGRADE.md

@@ -8,6 +8,11 @@ awareness about deprecated code.
 
 # Upgrade to 3.4
 
+## Deprecated removal of namespaced assets from schema.
+
+The `RemoveNamespacedAssets` schema visitor and the usage of namespaced database object names with the platforms
+that don't support them have been deprecated.
+
 ## Deprecated the functionality of checking schema for the usage of reserved keywords.
 
 The following components have been deprecated:

psalm.xml.dist

@@ -86,6 +86,10 @@
                 -->
                 <referencedClass name="Doctrine\DBAL\Platforms\Keywords\ReservedKeywordsValidator"/>
                 <referencedClass name="Doctrine\DBAL\Tools\Console\Command\ReservedWordsCommand"/>
+                <!--
+                    TODO: remove in 4.0.0
+                -->
+                <referencedClass name="Doctrine\DBAL\Schema\Visitor\RemoveNamespacedAssets"/>
             </errorLevel>
         </DeprecatedClass>
         <DeprecatedInterface>

src/Schema/Visitor/RemoveNamespacedAssets.php

@@ -6,6 +6,7 @@
 use Doctrine\DBAL\Schema\Schema;
 use Doctrine\DBAL\Schema\Sequence;
 use Doctrine\DBAL\Schema\Table;
+use Doctrine\Deprecations\Deprecation;
 
 /**
  * Removes assets from a schema that are not in the default namespace.
@@ -16,13 +17,25 @@
  * non default namespaces.
  *
  * This visitor filters all these non-default namespaced tables and sequences
- * and removes them from the SChema instance.
+ * and removes them from the Schema instance.
+ *
+ * @deprecated Do not use namespaces if the target database platform doesn't support them.
  */
 class RemoveNamespacedAssets extends AbstractVisitor
 {
     /** @var Schema|null */
     private $schema;
 
+    public function __construct()
+    {
+        Deprecation::trigger(
+            'doctrine/dbal',
+            'https://github.com/doctrine/dbal/pull/5432',
+            'RemoveNamespacedAssets is deprecated. Do not use namespaces'
+                . " if the target database platform doesn't support them."
+        );
+    }
+
     /**
      * {@inheritdoc}
      */