Turn on assertions

Turning them of results in a drop in coverage. Also, it is better to execute that code in case it is wrong.
doctrine · Oct 15, 2020 · 8ee26df · 8ee26df
1 parent f78bc33
commit 8ee26df
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/.github/workflows/continuous-integration.yml b/.github/workflows/continuous-integration.yml
@@ -40,6 +40,7 @@ jobs:
         with:
           php-version: "${{ matrix.php-version }}"
           coverage: "pcov"
+          ini-values: "zend.assertions=1"
 
       - name: "Cache dependencies installed with composer"
         uses: "actions/cache@v2"
@@ -93,6 +94,7 @@ jobs:
           php-version: "${{ matrix.php-version }}"
           extensions: "oci8"
           coverage: "pcov"
+          ini-values: "zend.assertions=1"
 
       - name: "Cache dependencies installed with composer"
         uses: "actions/cache@v2"
@@ -141,6 +143,7 @@ jobs:
           php-version: "${{ matrix.php-version }}"
           extensions: "pdo_oci"
           coverage: "pcov"
+          ini-values: "zend.assertions=1"
 
       - name: "Cache dependencies installed with composer"
         uses: "actions/cache@v2"
@@ -204,6 +207,7 @@ jobs:
         with:
           php-version: "${{ matrix.php-version }}"
           coverage: "pcov"
+          ini-values: "zend.assertions=1"
 
       - name: "Cache dependencies installed with composer"
         uses: "actions/cache@v2"
@@ -268,6 +272,7 @@ jobs:
         with:
           php-version: "${{ matrix.php-version }}"
           coverage: "pcov"
+          ini-values: "zend.assertions=1"
           extensions: "${{ matrix.extension }}"
 
       - name: "Cache dependencies installed with composer"
@@ -343,6 +348,7 @@ jobs:
         with:
           php-version: "${{ matrix.php-version }}"
           coverage: "pcov"
+          ini-values: "zend.assertions=1"
           extensions: "${{ matrix.extension }}"
 
       - name: "Cache dependencies installed with composer"
@@ -416,6 +422,7 @@ jobs:
         with:
           php-version: "${{ matrix.php-version }}"
           coverage: "pcov"
+          ini-values: "zend.assertions=1"
           tools: "pecl"
           extensions: "${{ matrix.extension }}-5.7.0preview"
 
@@ -478,7 +485,7 @@ jobs:
         with:
           php-version: "${{ matrix.php-version }}"
           coverage: "pcov"
-          ini-values: "extension=ibm_db2.so, ibm_db2.instance_name=db2inst1"
+          ini-values: "zend.assertions=1,extension=ibm_db2.so, ibm_db2.instance_name=db2inst1"
 
       - name: "Install ibm_db2 extension"
         run: "ci/github/ext/install-ibm_db2.sh ${{ matrix.php-version }}"