Merge pull request #5411 from morozov/sqlite-fk-revert

Mark SQLite platform as not supporting foreign keys
doctrine · May 24, 2022 · 7b85b8c · 7b85b8c
2 parents a14fb3f + 2e223d5
commit 7b85b8c
Show file tree

Hide file tree

Showing 4 changed files with 38 additions and 8 deletions.
diff --git a/src/Platforms/AbstractPlatform.php b/src/Platforms/AbstractPlatform.php
@@ -3708,18 +3708,10 @@ public function supportsPrimaryConstraints()
     /**
      * Whether the platform supports foreign key constraints.
      *
-     * @deprecated All platforms should support foreign key constraints.
-     *
      * @return bool
      */
     public function supportsForeignKeyConstraints()
     {
-        Deprecation::triggerIfCalledFromOutside(
-            'doctrine/dbal',
-            'https://github.com/doctrine/dbal/pulls/5409',
-            'AbstractPlatform::supportsForeignKeyConstraints() is deprecated.'
-        );
-
         return true;
     }
 

diff --git a/src/Platforms/SqlitePlatform.php b/src/Platforms/SqlitePlatform.php
@@ -841,6 +841,14 @@ public function canEmulateSchemas()
         return true;
     }
 
+    /**
+     * {@inheritDoc}
+     */
+    public function supportsForeignKeyConstraints()
+    {
+        return false;
+    }
+
     /**
      * {@inheritDoc}
      */

diff --git a/tests/Functional/Schema/SchemaManagerFunctionalTestCase.php b/tests/Functional/Schema/SchemaManagerFunctionalTestCase.php
@@ -498,6 +498,10 @@ public function testDropAndCreateUniqueConstraint(): void
 
     public function testCreateTableWithForeignKeys(): void
     {
+        if (! $this->connection->getDatabasePlatform()->supportsForeignKeyConstraints()) {
+            self::markTestSkipped('Platform does not support foreign keys.');
+        }
+
         $tableB = $this->getTestTable('test_foreign');
 
         $this->dropAndCreateTable($tableB);
@@ -675,6 +679,10 @@ public function testAlterTableScenario(): void
         // dont check for index size here, some platforms automatically add indexes for foreign keys.
         self::assertFalse($table->hasIndex('bar_idx'));
 
+        if (! $this->connection->getDatabasePlatform()->supportsForeignKeyConstraints()) {
+            return;
+        }
+
         $fks = $table->getForeignKeys();
         self::assertCount(1, $fks);
         $foreignKey = current($fks);
@@ -775,6 +783,12 @@ public function testAutoincrementDetectionMulticolumns(): void
      */
     public function testUpdateSchemaWithForeignKeyRenaming(callable $comparatorFactory): void
     {
+        $platform = $this->connection->getDatabasePlatform();
+
+        if (! $platform->supportsForeignKeyConstraints()) {
+            self::markTestSkipped('This test is only supported on platforms that have foreign keys.');
+        }
+
         $table = new Table('test_fk_base');
         $table->addColumn('id', 'integer');
         $table->setPrimaryKey(['id']);
@@ -821,6 +835,12 @@ public function testUpdateSchemaWithForeignKeyRenaming(callable $comparatorFacto
      */
     public function testRenameIndexUsedInForeignKeyConstraint(callable $comparatorFactory): void
     {
+        $platform = $this->connection->getDatabasePlatform();
+
+        if (! $platform->supportsForeignKeyConstraints()) {
+            self::markTestSkipped('This test is only supported on platforms that have foreign keys.');
+        }
+
         $primaryTable = new Table('test_rename_index_primary');
         $primaryTable->addColumn('id', 'integer');
         $primaryTable->setPrimaryKey(['id']);
@@ -1563,6 +1583,10 @@ public function testCommentInTable(): void
 
     public function testCreatedCompositeForeignKeyOrderIsCorrectAfterCreation(): void
     {
+        if (! $this->connection->getDatabasePlatform()->supportsForeignKeyConstraints()) {
+            self::markTestSkipped('Platform does not support foreign keys.');
+        }
+
         $foreignKey     = 'fk_test_order';
         $localTable     = 'test_table_foreign';
         $foreignTable   = 'test_table_local';

diff --git a/tests/Platforms/AbstractPlatformTestCase.php b/tests/Platforms/AbstractPlatformTestCase.php
@@ -1072,6 +1072,12 @@ protected function getQuotedAlterTableRenameIndexInSchemaSQL(): array
 
     public function testQuotesDropForeignKeySQL(): void
     {
+        if (! $this->platform->supportsForeignKeyConstraints()) {
+            $this->markTestSkipped(
+                sprintf('%s does not support foreign key constraints.', get_class($this->platform))
+            );
+        }
+
         $tableName      = 'table';
         $table          = new Table($tableName);
         $foreignKeyName = 'select';