Remove suppression for MissingNativeTypeHint errors

doctrine · Sep 17, 2021 · 6364198 · 6364198
1 parent ca49b75
commit 6364198
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 14 deletions.
diff --git a/phpcs.xml.dist b/phpcs.xml.dist
@@ -48,14 +48,6 @@
         <exclude-pattern>*/src/Tools/Console/Helper/ConnectionHelper.php</exclude-pattern>
     </rule>
 
-    <rule ref="SlevomatCodingStandard.TypeHints.ParameterTypeHint.MissingNativeTypeHint">
-        <exclude-pattern>*/src/*</exclude-pattern>
-    </rule>
-
-    <rule ref="SlevomatCodingStandard.TypeHints.ReturnTypeHint.MissingNativeTypeHint">
-        <exclude-pattern>*/src/*</exclude-pattern>
-    </rule>
-
     <rule ref="PSR1.Classes.ClassDeclaration.MultipleClasses">
         <exclude-pattern>*/lib/Doctrine/DBAL/Driver/PDOQueryImplementation.php</exclude-pattern>
         <exclude-pattern>*/lib/Doctrine/DBAL/Driver/PDOStatementImplementations.php</exclude-pattern>

diff --git a/src/Connection.php b/src/Connection.php
@@ -619,7 +619,7 @@ public function insert(string $table, array $data, array $types = []): int
      *
      * @return array<int, int|string|Type|null>|array<string, int|string|Type|null>
      */
-    private function extractTypeValues(array $columnList, array $types)
+    private function extractTypeValues(array $columnList, array $types): array
     {
         $typeValues = [];
 

diff --git a/src/Driver/OCI8/Connection.php b/src/Driver/OCI8/Connection.php
@@ -94,7 +94,7 @@ public function exec(string $sql): int
         return $this->prepare($sql)->execute()->rowCount();
     }
 
-    public function lastInsertId()
+    public function lastInsertId(): void
     {
         throw IdentityColumnsNotSupported::new();
     }

diff --git a/src/Platforms/SQLServerPlatform.php b/src/Platforms/SQLServerPlatform.php
@@ -1473,10 +1473,7 @@ public function getListTableMetadataSQL(string $table): string
         );
     }
 
-    /**
-     * @param string $query
-     */
-    private function shouldAddOrderBy($query): bool
+    private function shouldAddOrderBy(string $query): bool
     {
         // Find the position of the last instance of ORDER BY and ensure it is not within a parenthetical statement
         // but can be in a newline