Merge pull request #3255 from Majkl578/dev/removal/Type-getDefaultLength

Remove Doctrine\DBAL\Types\Type::getDefaultLength()

UPGRADE.md

@@ -1,5 +1,9 @@
 # Upgrade to 3.0
 
+## BC BREAK: `Doctrine\DBAL\Types\Type::getDefaultLength()` removed
+
+The `Doctrine\DBAL\Types\Type::getDefaultLength()` method has been removed as it served no purpose.
+
 ## BC BREAK: `Doctrine\DBAL\Types\Type::__toString()` removed
 
 Relying on string representation was discouraged and has been removed.

lib/Doctrine/DBAL/Types/StringType.php

@@ -19,14 +19,6 @@ public function getSQLDeclaration(array $fieldDeclaration, AbstractPlatform $pla
         return $platform->getVarcharTypeDeclarationSQL($fieldDeclaration);
     }
 
-    /**
-     * {@inheritdoc}
-     */
-    public function getDefaultLength(AbstractPlatform $platform)
-    {
-        return $platform->getVarcharDefaultLength();
-    }
-
     /**
      * {@inheritdoc}
      */

lib/Doctrine/DBAL/Types/Type.php

@@ -122,20 +122,6 @@ public function convertToPHPValue($value, AbstractPlatform $platform)
         return $value;
     }
 
-    /**
-     * Gets the default length of this type.
-     *
-     * @param \Doctrine\DBAL\Platforms\AbstractPlatform $platform
-     *
-     * @return int|null
-     *
-     * @todo Needed?
-     */
-    public function getDefaultLength(AbstractPlatform $platform)
-    {
-        return null;
-    }
-
     /**
      * Gets the SQL declaration snippet for a field of this type.
      *

tests/Doctrine/Tests/DBAL/Types/StringTest.php

@@ -28,11 +28,6 @@ public function testReturnsSqlDeclarationFromPlatformVarchar()
         self::assertEquals("DUMMYVARCHAR()", $this->_type->getSqlDeclaration(array(), $this->_platform));
     }
 
-    public function testReturnsDefaultLengthFromPlatformVarchar()
-    {
-        self::assertEquals(255, $this->_type->getDefaultLength($this->_platform));
-    }
-
     public function testConvertToPHPValue()
     {
         self::assertInternalType("string", $this->_type->convertToPHPValue("foo", $this->_platform));