Merge pull request #3192 from morozov/issues/3187

Added more information to the deprecation notice
doctrine · Jun 20, 2018 · 3979efe · 3979efe
2 parents c0f6d4b + 104ae16
commit 3979efe
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 8 deletions.
diff --git a/lib/Doctrine/DBAL/Platforms/AbstractPlatform.php b/lib/Doctrine/DBAL/Platforms/AbstractPlatform.php
@@ -332,7 +332,7 @@ public function getBinaryTypeDeclarationSQL(array $field)
         if ($field['length'] > $maxLength) {
             if ($maxLength > 0) {
                 @trigger_error(sprintf(
-                    'Binary field length %d is greater than supported by the platform (%d)',
+                    'Binary field length %d is greater than supported by the platform (%d). Reduce the field length or use a BLOB field instead.',
                     $field['length'],
                     $maxLength
                 ), E_USER_DEPRECATED);

diff --git a/tests/Doctrine/Tests/DBAL/Platforms/AbstractMySQLPlatformTestCase.php b/tests/Doctrine/Tests/DBAL/Platforms/AbstractMySQLPlatformTestCase.php
@@ -527,9 +527,9 @@ public function testReturnsBinaryTypeDeclarationSQL()
 
     /**
      * @group legacy
-     * @expectedDeprecation Binary field length 65536 is greater than supported by the platform (65535)
-     * @expectedDeprecation Binary field length 16777215 is greater than supported by the platform (65535)
-     * @expectedDeprecation Binary field length 16777216 is greater than supported by the platform (65535)
+     * @expectedDeprecation Binary field length 65536 is greater than supported by the platform (65535). Reduce the field length or use a BLOB field instead.
+     * @expectedDeprecation Binary field length 16777215 is greater than supported by the platform (65535). Reduce the field length or use a BLOB field instead.
+     * @expectedDeprecation Binary field length 16777216 is greater than supported by the platform (65535). Reduce the field length or use a BLOB field instead.
      */
     public function testReturnsBinaryTypeLongerThanMaxDeclarationSQL()
     {

diff --git a/tests/Doctrine/Tests/DBAL/Platforms/AbstractSQLServerPlatformTestCase.php b/tests/Doctrine/Tests/DBAL/Platforms/AbstractSQLServerPlatformTestCase.php
@@ -989,7 +989,7 @@ public function testReturnsBinaryTypeDeclarationSQL()
 
     /**
      * @group legacy
-     * @expectedDeprecation Binary field length 8001 is greater than supported by the platform (8000)
+     * @expectedDeprecation Binary field length 8001 is greater than supported by the platform (8000). Reduce the field length or use a BLOB field instead.
      */
     public function testReturnsBinaryTypeLongerThanMaxDeclarationSQL()
     {

diff --git a/tests/Doctrine/Tests/DBAL/Platforms/DB2PlatformTest.php b/tests/Doctrine/Tests/DBAL/Platforms/DB2PlatformTest.php
@@ -429,7 +429,7 @@ public function testReturnsBinaryTypeDeclarationSQL()
 
     /**
      * @group legacy
-     * @expectedDeprecation Binary field length 32705 is greater than supported by the platform (32704)
+     * @expectedDeprecation Binary field length 32705 is greater than supported by the platform (32704). Reduce the field length or use a BLOB field instead.
      */
     public function testReturnsBinaryTypeLongerThanMaxDeclarationSQL()
     {

diff --git a/tests/Doctrine/Tests/DBAL/Platforms/OraclePlatformTest.php b/tests/Doctrine/Tests/DBAL/Platforms/OraclePlatformTest.php
@@ -454,7 +454,7 @@ public function testReturnsBinaryTypeDeclarationSQL()
 
     /**
      * @group legacy
-     * @expectedDeprecation Binary field length 2001 is greater than supported by the platform (2000)
+     * @expectedDeprecation Binary field length 2001 is greater than supported by the platform (2000). Reduce the field length or use a BLOB field instead.
      */
     public function testReturnsBinaryTypeLongerThanMaxDeclarationSQL()
     {

diff --git a/tests/Doctrine/Tests/DBAL/Platforms/SQLAnywherePlatformTest.php b/tests/Doctrine/Tests/DBAL/Platforms/SQLAnywherePlatformTest.php
@@ -799,7 +799,7 @@ public function testReturnsBinaryTypeDeclarationSQL()
 
     /**
      * @group legacy
-     * @expectedDeprecation Binary field length 32768 is greater than supported by the platform (32767)
+     * @expectedDeprecation Binary field length 32768 is greater than supported by the platform (32767). Reduce the field length or use a BLOB field instead.
      */
     public function testReturnsBinaryTypeLongerThanMaxDeclarationSQL()
     {