Merge pull request #782 from Ocramius/hotfix/sqlite-offset-with-no-li…

…mit-support Fix: SQLite offset with no limit support
doctrine · Jan 24, 2015 · 2a9dd3c · 2a9dd3c
2 parents 170817a + 74f2bee
commit 2a9dd3c
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/lib/Doctrine/DBAL/Platforms/SqlitePlatform.php b/lib/Doctrine/DBAL/Platforms/SqlitePlatform.php
@@ -657,6 +657,18 @@ protected function getPostAlterTableIndexForeignKeySQL(TableDiff $diff)
         return $sql;
     }
 
+    /**
+     * {@inheritDoc}
+     */
+    protected function doModifyLimitQuery($query, $limit, $offset)
+    {
+        if (null === $limit && null !== $offset) {
+            return $query . ' LIMIT -1 OFFSET ' . $offset;
+        }
+
+        return parent::doModifyLimitQuery($query, $limit, $offset);
+    }
+
     /**
      * {@inheritDoc}
      */

diff --git a/tests/Doctrine/Tests/DBAL/Platforms/SqlitePlatformTest.php b/tests/Doctrine/Tests/DBAL/Platforms/SqlitePlatformTest.php
@@ -288,6 +288,12 @@ public function testModifyLimitQueryWithEmptyOffset()
         $this->assertEquals('SELECT * FROM user LIMIT 10', $sql);
     }
 
+    public function testModifyLimitQueryWithOffsetAndEmptyLimit()
+    {
+        $sql = $this->_platform->modifyLimitQuery('SELECT * FROM user', null, 10);
+        $this->assertEquals('SELECT * FROM user LIMIT -1 OFFSET 10', $sql);
+    }
+
     public function getGenerateAlterTableSql()
     {
         return array(