Remove AbstractPlatform::hasNative*Type() methods

UPGRADE.md

@@ -211,6 +211,8 @@ Postgres 9 is not actively supported anymore. The following classes have been me
 
 The following methods are removed:
 
+- `AbstractPlatform::hasNativeJsonType()`
+- `AbstractPlatform::hasNativeGuidType()`
 - `AbstractPlatform::isCommentedDoctrineType()`
 - `AbstractPlatform::initializeCommentedDoctrineTypes()`
 - `AbstractPlatform::markDoctrineTypeCommented()`

psalm.xml.dist

@@ -39,12 +39,6 @@
                     See https://github.com/doctrine/dbal/pull/4317
                 -->
                 <file name="tests/Functional/LegacyAPITest.php"/>
-                <!--
-                    TODO: remove in 4.0.0
-                -->
-                <referencedMethod name="Doctrine\DBAL\Platforms\AbstractPlatform::hasNativeGuidType"/>
-                <referencedMethod name="Doctrine\DBAL\Platforms\AbstractPlatform::hasNativeJsonType"/>
-                <referencedMethod name="Doctrine\DBAL\Platforms\PostgreSQLPlatform::hasNativeJsonType"/>
             </errorLevel>
         </DeprecatedMethod>
         <DocblockTypeContradiction>

src/Platforms/AbstractPlatform.php

@@ -37,7 +37,6 @@
 use Doctrine\DBAL\Types;
 use Doctrine\DBAL\Types\Exception\TypeNotFound;
 use Doctrine\DBAL\Types\Type;
-use Doctrine\Deprecations\Deprecation;
 use InvalidArgumentException;
 use UnexpectedValueException;
 
@@ -2286,40 +2285,6 @@ public function supportsCommentOnStatement(): bool
         return false;
     }
 
-    /**
-     * Does this platform have native guid type.
-     *
-     * @deprecated
-     */
-    public function hasNativeGuidType(): bool
-    {
-        Deprecation::triggerIfCalledFromOutside(
-            'doctrine/dbal',
-            'https://github.com/doctrine/dbal/pull/5509',
-            '%s is deprecated.',
-            __METHOD__
-        );
-
-        return false;
-    }
-
-    /**
-     * Does this platform have native JSON type.
-     *
-     * @deprecated
-     */
-    public function hasNativeJsonType(): bool
-    {
-        Deprecation::triggerIfCalledFromOutside(
-            'doctrine/dbal',
-            'https://github.com/doctrine/dbal/pull/5509',
-            '%s is deprecated.',
-            __METHOD__
-        );
-
-        return false;
-    }
-
     /**
      * Does this platform support column collation?
      */

src/Platforms/MySQLPlatform.php

@@ -32,11 +32,6 @@ public function getDefaultValueDeclarationSQL(array $column): string
         return parent::getDefaultValueDeclarationSQL($column);
     }
 
-    public function hasNativeJsonType(): bool
-    {
-        return true;
-    }
-
     /**
      * {@inheritdoc}
      */

src/Platforms/PostgreSQLPlatform.php

@@ -16,7 +16,6 @@
 use Doctrine\DBAL\Schema\TableDiff;
 use Doctrine\DBAL\Types\BinaryType;
 use Doctrine\DBAL\Types\BlobType;
-use Doctrine\Deprecations\Deprecation;
 use UnexpectedValueException;
 
 use function array_diff;
@@ -155,21 +154,6 @@ public function supportsCommentOnStatement(): bool
         return true;
     }
 
-    /**
-     * @deprecated
-     */
-    public function hasNativeGuidType(): bool
-    {
-        Deprecation::triggerIfCalledFromOutside(
-            'doctrine/dbal',
-            'https://github.com/doctrine/dbal/pull/5509',
-            '%s is deprecated.',
-            __METHOD__
-        );
-
-        return true;
-    }
-
     public function getListDatabasesSQL(): string
     {
         return 'SELECT datname FROM pg_database';
@@ -823,21 +807,6 @@ protected function initializeDoctrineTypeMappings(): void
         ];
     }
 
-    /**
-     * @deprecated
-     */
-    public function hasNativeJsonType(): bool
-    {
-        Deprecation::triggerIfCalledFromOutside(
-            'doctrine/dbal',
-            'https://github.com/doctrine/dbal/pull/5509',
-            '%s is deprecated.',
-            __METHOD__
-        );
-
-        return true;
-    }
-
     protected function createReservedKeywordsList(): KeywordList
     {
         return new PostgreSQLKeywords();

src/Platforms/SQLServerPlatform.php

@@ -17,7 +17,6 @@
 use Doctrine\DBAL\Schema\Sequence;
 use Doctrine\DBAL\Schema\SQLServerSchemaManager;
 use Doctrine\DBAL\Schema\TableDiff;
-use Doctrine\Deprecations\Deprecation;
 use InvalidArgumentException;
 
 use function array_merge;
@@ -155,21 +154,6 @@ public function getSequenceNextValSQL(string $sequence): string
         return 'SELECT NEXT VALUE FOR ' . $sequence;
     }
 
-    /**
-     * @deprecated
-     */
-    public function hasNativeGuidType(): bool
-    {
-        Deprecation::triggerIfCalledFromOutside(
-            'doctrine/dbal',
-            'https://github.com/doctrine/dbal/pull/5509',
-            '%s is deprecated.',
-            __METHOD__
-        );
-
-        return true;
-    }
-
     public function getDropForeignKeySQL(string $foreignKey, string $table): string
     {
         return $this->getDropConstraintSQL($foreignKey, $table);

tests/Functional/Schema/SchemaManagerFunctionalTestCase.php

@@ -1116,26 +1116,6 @@ public function testDoesNotListIndexesImplicitlyCreatedByForeignKeys(): void
         self::assertArrayHasKey('idx_3d6c147fdc58d6c', $indexes);
     }
 
-    public function testComparatorShouldNotAddCommentToJsonTypeSinceItIsTheDefaultNow(): void
-    {
-        $platform = $this->connection->getDatabasePlatform();
-
-        if (! $platform->hasNativeJsonType()) {
-            self::markTestSkipped('This test is only supported on platforms that have native JSON type.');
-        }
-
-        $this->dropTableIfExists('json_test');
-        $this->connection->executeQuery('CREATE TABLE json_test (parameters JSON NOT NULL)');
-
-        $table = new Table('json_test');
-        $table->addColumn('parameters', 'json');
-
-        $tableDiff = $this->schemaManager->createComparator()
-            ->diffTable($this->schemaManager->listTableDetails('json_test'), $table);
-
-        self::assertNull($tableDiff);
-    }
-
     public function testCreateAndListSequences(): void
     {
         if (! $this->connection->getDatabasePlatform()->supportsSequences()) {

tests/Platforms/AbstractPlatformTestCase.php

@@ -817,11 +817,6 @@ public function getExpectedVariableLengthBinaryTypeDeclarationSQLWithLength(): s
         return 'VARBINARY(16)';
     }
 
-    public function hasNativeJsonType(): void
-    {
-        self::assertFalse($this->platform->hasNativeJsonType());
-    }
-
     public function testReturnsJsonTypeDeclarationSQL(): void
     {
         $column = [

tests/Platforms/MariaDBPlatformTest.php

@@ -15,11 +15,6 @@ public function createPlatform(): AbstractPlatform
         return new MariaDBPlatform();
     }
 
-    public function testHasNativeJsonType(): void
-    {
-        self::assertFalse($this->platform->hasNativeJsonType());
-    }
-
     /**
      * From MariaDB 10.2.7, JSON type is an alias to LONGTEXT
      *

tests/Platforms/MySQLPlatformTest.php

@@ -20,11 +20,6 @@ public function createPlatform(): AbstractPlatform
         return new MySQLPlatform();
     }
 
-    public function testHasNativeJsonType(): void
-    {
-        self::assertTrue($this->platform->hasNativeJsonType());
-    }
-
     public function testReturnsJsonTypeDeclarationSQL(): void
     {
         self::assertSame('JSON', $this->platform->getJsonTypeDeclarationSQL([]));

tests/Platforms/PostgreSQLPlatformTest.php

@@ -897,11 +897,6 @@ public function testColumnCollationDeclarationSQL(): void
         );
     }
 
-    public function testHasNativeJsonType(): void
-    {
-        self::assertTrue($this->platform->hasNativeJsonType());
-    }
-
     public function testReturnsJsonTypeDeclarationSQL(): void
     {
         self::assertSame('JSON', $this->platform->getJsonTypeDeclarationSQL([]));