Merge pull request #4401 from BenMorel/unused-var

Add missing instanceof check
doctrine · Nov 3, 2020 · 1a9da6d · 1a9da6d
2 parents 83113ce + d76bf72
commit 1a9da6d
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/psalm.xml b/psalm.xml
@@ -89,6 +89,15 @@
                 <file name="src/Schema/AbstractSchemaManager.php"/>
             </errorLevel>
         </PossiblyNullArgument>
+        <RedundantCondition>
+            <errorLevel type="suppress">
+                <!--
+                    Requires a release of
+                    https://github.com/sebastianbergmann/phpunit/commit/9c60d7d9fd3bfa80fa4aeab7090e1bbe0830dbcd
+                -->
+                <file name="tests/Driver/API/ExceptionConverterTest.php"/>
+            </errorLevel>
+        </RedundantCondition>
         <TooFewArguments>
             <errorLevel type="suppress">
                 <!--

diff --git a/tests/Driver/API/ExceptionConverterTest.php b/tests/Driver/API/ExceptionConverterTest.php
@@ -51,6 +51,7 @@ public function testConvertsException(
 
         $dbalException = $this->converter->convert($driverException, $query);
 
+        self::assertInstanceOf($expectedClass, $dbalException);
         self::assertSame($driverException->getCode(), $dbalException->getCode());
         self::assertSame($driverException->getSQLState(), $dbalException->getSQLState());
         self::assertSame($driverException, $dbalException->getPrevious());