Deprecate SchemaDiff::$fromSchema

doctrine · Sep 11, 2022 · 0a17cb6 · 0a17cb6
1 parent 58beef0
commit 0a17cb6
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 1 deletion.
diff --git a/UPGRADE.md b/UPGRADE.md
@@ -62,6 +62,10 @@ The constructors of the following classes have been marked as internal:
 These classes can be instantiated only by schema comparators. The signatures of the constructors may change in future
 versions.
 
+## Deprecated `SchemaDiff` reference to the original schema.
+
+The `SchemaDiff::$fromSchema` property has been deprecated.
+
 ## Marked `AbstractSchemaManager::_execSql()` as internal.
 
 The `AbstractSchemaManager::_execSql()` method has been marked as internal. It will not be available in 4.0.

diff --git a/psalm.xml.dist b/psalm.xml.dist
@@ -455,6 +455,10 @@
                 <!--
                     TODO: remove in 4.0.0
                 -->
+                <referencedProperty name="Doctrine\DBAL\Schema\SchemaDiff::$fromSchema"/>
+                <!--
+                    TODO: remove in 4.0.0
+                -->
                 <referencedProperty name="Doctrine\DBAL\Schema\ColumnDiff::$oldColumnName"/>
                 <!--
                     TODO: remove in 4.0.0

diff --git a/src/Schema/SchemaDiff.php b/src/Schema/SchemaDiff.php
@@ -14,7 +14,11 @@
  */
 class SchemaDiff
 {
-    /** @var Schema|null */
+    /**
+     * @deprecated
+     *
+     * @var Schema|null
+     */
     public $fromSchema;
 
     /**