Dropped SQL Server 2008 support

.appveyor.yml

@@ -18,11 +18,6 @@ cache:
 ## Build matrix for lowest and highest possible targets
 environment:
   matrix:
-  - db: mssql
-    driver: sqlsrv
-    db_version: sql2008r2sp2
-    coverage: yes
-    php: 7.3
   - db: mssql
     driver: sqlsrv
     db_version: sql2012sp1

UPGRADE.md

@@ -52,18 +52,22 @@ The following classes have been removed:
  * `Doctrine\DBAL\Platforms\Keywords\SQLAnywhere12Keywords`
  * `Doctrine\DBAL\Platforms\Keywords\SQLAnywhere16Keywords`
 
-## BC BREAK: Removed support for SQL Server 2005 and older
+## BC BREAK: Removed support for SQL Server 2008 and older
 
-DBAL now requires SQL Server 2008 or newer, support for unmaintained versions has been dropped.
-If you are using any of the legacy versions, you have to upgrade to newer SQL Server version (2012+ is recommended).
-`Doctrine\DBAL\Platforms\SQLServerPlatform` and `Doctrine\DBAL\Platforms\Keywords\SQLServerKeywords` now represent the SQL Server 2008.
+DBAL now requires SQL Server 2012 or newer, support for unmaintained versions has been dropped.
+If you are using any of the legacy versions, you have to upgrade to a newer SQL Server version.
+`Doctrine\DBAL\Platforms\SQLServerPlatform` and `Doctrine\DBAL\Platforms\Keywords\SQLServerKeywords` now represent SQL Server 2012.
 
 The following classes have been removed:
 
  * `Doctrine\DBAL\Platforms\SQLServer2005Platform`
  * `Doctrine\DBAL\Platforms\SQLServer2008Platform`
+ * `Doctrine\DBAL\Platforms\SQLServer2012Platform`
  * `Doctrine\DBAL\Platforms\Keywords\SQLServer2005Keywords`
  * `Doctrine\DBAL\Platforms\Keywords\SQLServer2008Keywords`
+ * `Doctrine\DBAL\Platforms\Keywords\SQLServer2012Keywords`
+
+The `AbstractSQLServerDriver` class and its subclasses no longer implement the `VersionAwarePlatformDriver` interface.
 
 ## BC BREAK: Removed support for PostgreSQL 9.2 and older
 

docs/en/reference/platforms.rst

@@ -50,8 +50,7 @@ Oracle
 Microsoft SQL Server
 ^^^^^^^^^^^^^^^^^^^^
 
--  ``SQLServerPlatform`` for version 2008 and above.
--  ``SQLServer2012Platform`` for version 2012 and above.
+-  ``SQLServerPlatform`` for version 2012 and above.
 
 PostgreSQL
 ^^^^^^^^^^

lib/Doctrine/DBAL/Driver/AbstractSQLServerDriver.php

@@ -3,49 +3,15 @@
 namespace Doctrine\DBAL\Driver;
 
 use Doctrine\DBAL\Connection;
-use Doctrine\DBAL\DBALException;
-use Doctrine\DBAL\Platforms\SQLServer2012Platform;
+use Doctrine\DBAL\Driver;
 use Doctrine\DBAL\Platforms\SQLServerPlatform;
 use Doctrine\DBAL\Schema\SQLServerSchemaManager;
-use Doctrine\DBAL\VersionAwarePlatformDriver;
-use function preg_match;
-use function version_compare;
 
 /**
  * Abstract base implementation of the {@link Doctrine\DBAL\Driver} interface for Microsoft SQL Server based drivers.
  */
-abstract class AbstractSQLServerDriver implements VersionAwarePlatformDriver
+abstract class AbstractSQLServerDriver implements Driver
 {
-    /**
-     * {@inheritdoc}
-     */
-    public function createDatabasePlatformForVersion($version)
-    {
-        if (! preg_match(
-            '/^(?P<major>\d+)(?:\.(?P<minor>\d+)(?:\.(?P<patch>\d+)(?:\.(?P<build>\d+))?)?)?/',
-            $version,
-            $versionParts
-        )) {
-            throw DBALException::invalidPlatformVersionSpecified(
-                $version,
-                '<major_version>.<minor_version>.<patch_version>.<build_version>'
-            );
-        }
-
-        $majorVersion = $versionParts['major'];
-        $minorVersion = $versionParts['minor'] ?? 0;
-        $patchVersion = $versionParts['patch'] ?? 0;
-        $buildVersion = $versionParts['build'] ?? 0;
-        $version      = $majorVersion . '.' . $minorVersion . '.' . $patchVersion . '.' . $buildVersion;
-
-        switch (true) {
-            case version_compare($version, '11.00.2100', '>='):
-                return new SQLServer2012Platform();
-            default:
-                return new SQLServerPlatform();
-        }
-    }
-
     /**
      * {@inheritdoc}
      */

lib/Doctrine/DBAL/Platforms/Keywords/SQLServerKeywords.php

@@ -171,6 +171,9 @@ protected function getKeywords()
             'SCHEMA',
             'SECURITYAUDIT',
             'SELECT',
+            'SEMANTICKEYPHRASETABLE',
+            'SEMANTICSIMILARITYDETAILSTABLE',
+            'SEMANTICSIMILARITYTABLE',
             'SESSION_USER',
             'SET',
             'SETUSER',
@@ -188,6 +191,7 @@ protected function getKeywords()
             'TRANSACTION',
             'TRIGGER',
             'TRUNCATE',
+            'TRY_CONVERT',
             'TSEQUAL',
             'UNION',
             'UNIQUE',
@@ -204,6 +208,7 @@ protected function getKeywords()
             'WHERE',
             'WHILE',
             'WITH',
+            'WITHIN GROUP',
             'WRITETEXT',
         ];
     }