Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DependentFixtureInterface return documentation #342

Closed
wants to merge 1 commit into from
Closed

Fix DependentFixtureInterface return documentation #342

wants to merge 1 commit into from

Conversation

orolyn
Copy link

@orolyn orolyn commented Jan 17, 2020

This issue is causing problems for static analysis on projects using this library. Perhaps it was merely forgotten when introducing pslam?

@greg0ire
Copy link
Member

Are you using an up-to-date version of psalm? @ruudk please advise.

@orolyn
Copy link
Author

orolyn commented Jan 17, 2020

We're not using psalm. However we are using phpstan, the return type of class-string[] makes phpstan expect a return type of class, failing static analysis.

@alcaeus
Copy link
Member

alcaeus commented Jan 17, 2020

Closing: See #337 and #339. Upgrade to recent versions of phpstan (^0.12 IIRC) and it will work.

@alcaeus alcaeus closed this Jan 17, 2020
@alcaeus alcaeus self-assigned this Jan 17, 2020
@greg0ire
Copy link
Member

Are you using an up-to-date version of phpstan?

@orolyn
Copy link
Author

orolyn commented Jan 17, 2020

0.11, updating it now, thanks.

@orolyn orolyn deleted the fix-dep-class-return-param branch January 17, 2020 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants