Added OutOfBoundsException for undefined Reference

doctrine · Mar 23, 2015 · fbd7ef9 · fbd7ef9
1 parent 64dfaae
commit fbd7ef9
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/lib/Doctrine/Common/DataFixtures/ReferenceRepository.php b/lib/Doctrine/Common/DataFixtures/ReferenceRepository.php
@@ -147,10 +147,15 @@ public function addReference($name, $object)
      * named by $name
      *
      * @param string $name
+     * @throws OutOfBoundsException - if repository does not exist
      * @return object
      */
     public function getReference($name)
     {
+        if (!$this->hasReference($name)) {
+            throw new \OutOfBoundsException("Reference to: ({$name}) does not exist");
+        }
+
         $reference = $this->references[$name];
         $meta = $this->manager->getClassMetadata(get_class($reference));
         $uow = $this->manager->getUnitOfWork();

diff --git a/tests/Doctrine/Tests/Common/DataFixtures/ReferenceRepositoryTest.php b/tests/Doctrine/Tests/Common/DataFixtures/ReferenceRepositoryTest.php
@@ -132,4 +132,15 @@ public function testReferenceMultipleEntries()
         $this->assertInstanceOf('Doctrine\ORM\Proxy\Proxy', $referenceRepository->getReference('admin'));
         $this->assertInstanceOf('Doctrine\ORM\Proxy\Proxy', $referenceRepository->getReference('duplicate'));
     }
+
+    /**
+     * @expectedException OutOfBoundsException
+     * @expectedExceptionMessage Reference to: (foo) does not exist
+     */
+    public function testUndefinedReference()
+    {
+        $em = $this->getMockSqliteEntityManager();
+        $referenceRepository = new ReferenceRepository($em);
+        $referenceRepository->getReference('foo');
+    }
 }