fix: do not cast BackedEnum identifiers to int #1000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gwemox
changed the title
Gwemox
force-pushed
the
fix/dont-cast-backedenum
branch
4 times, most recently
from
4c55779 to
1f02a2e
Compare
Gwemox
force-pushed
the
fix/dont-cast-backedenum
branch
from
1f02a2e to
8e2f83c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another way to solve #997
Thank's to @malarzm for the test (#998)
The applied solution: only cast to
intif return value is not a instance ofBackedEnum.Another solution would be to check the return value is numeric (is_numeric) but if it is null it will change the behavior (
nullinstead of0)