reduce method: more accurate types #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gharlan
commented
Feb 21, 2024
| * @psalm-param Closure(TReturn|TInitial|null, T):(TInitial|TReturn) $func | ||
| * @psalm-param TInitial|null $initial | ||
| * @psalm-param Closure(TReturn|TInitial, T):TReturn $func | ||
| * @psalm-param TInitial $initial |
There was a problem hiding this comment.
If $initial is not null, the closure does not need to accept null value for first param.
|
This was introduced in #252 |
I dunno where I found the types, but i copied them from somewhere else, Searching for similar types in psalm, I found This PR seems to go in the right direction |
greg0ire
approved these changes
Feb 21, 2024
SenseException
approved these changes
Feb 21, 2024
|
Thanks @gharlan ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.