Deprecate passing null as offset #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
reviewed
Aug 4, 2022
derrabus
force-pushed
the
deprecate/null-offset
branch
from
9d8e627
to
c776f38
Compare
derrabus
force-pushed
the
deprecate/null-offset
branch
from
c776f38
to
a3437f5
Compare
greg0ire
approved these changes
Aug 4, 2022
mbabker
pushed a commit
to BabDev/Pagerfanta
that referenced
this pull request
Feb 1, 2024
Fixes deprecation: ``` Passing null to Doctrine\Common\Collections\Criteria::setFirstResult() is deprecated, pass 0 instead. ``` Deprecation info: doctrine/collections#311
mbabker
pushed a commit
to Pagerfanta/doctrine-collections-adapter
that referenced
this pull request
Feb 1, 2024
Fixes deprecation: ``` Passing null to Doctrine\Common\Collections\Criteria::setFirstResult() is deprecated, pass 0 instead. ``` Deprecation info: doctrine/collections#311
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to be able to narrow down parameter and return types for 2.0, I think we should disallow using
nullas offset forCriteriainstances. We've applied similar changes to DBAL and ORM already.