Remove calls to TestCase::at() #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
force-pushed
the
refactor-away-from-at
branch
from
6b98f65 to
e7a4e10
Compare
greg0ire
commented
Aug 1, 2020
greg0ire
force-pushed
the
refactor-away-from-at
branch
2 times, most recently
from
4e06f2f to
f99bbe1
Compare
I noticed transient tests that have to do with |
greg0ire
force-pushed
the
refactor-away-from-at
branch
from
f99bbe1 to
2e7939b
Compare
|
Cc @bastnic in case you have ideas |
| [$this->equalTo($cacheKeyMethod2)], | ||
| [$this->equalTo('[C]' . $cacheKeyMethod2)] | ||
| ) | ||
| ->will($this->onConsecutiveCalls( |
There was a problem hiding this comment.
willReturnOnConsecutiveCalls() should do the trick.
Maybe that would help. What would that look like? |
It could be a test that is using a real cache implementation like a custom one or maybe the |
greg0ire
force-pushed
the
refactor-away-from-at
branch
2 times, most recently
from
4c76007 to
fdb4ca4
Compare
|
Well… I restarted the build several times tonight and could not reproduce the issue, so I guess it was more transient than I thought, meaning it's probably not related to my changes. @SenseException , I made the changes you requested, please review again. |
It has been deprecated as of PHPUnit 9 Note that we still rely on the call order here, I am not the original author of this test but the order looks like it is pretty important for this test, or maybe at least for understanding it. Also note that we no longer check that save() is called after all calls to fetch().
greg0ire
force-pushed
the
refactor-away-from-at
branch
from
fdb4ca4 to
dd251d7
Compare
stof
approved these changes
Aug 10, 2020
jkufner
added a commit
to smalldb/annotations
that referenced
this pull request
Aug 11, 2020
Release [1.10.4](https://github.com/doctrine/annotations/milestone/25) 1.10.4 ====== - Total issues resolved: **0** - Total pull requests resolved: **8** - Total contributors: **5** - [347: Add support for the new PHP 8 tokens for use statements](doctrine#347) thanks to @stof - [345: Remove calls to TestCase::at()](doctrine#345) thanks to @greg0ire - [343: Allow using PHPUnit 9.3](doctrine#343) thanks to @greg0ire Improvement ----------- - [342: Upgrade phpunit](doctrine#342) thanks to @greg0ire - [332: DocParser: Improve private typehints](doctrine#332) thanks to @jkufner bug --- - [341: Make type in phpdoc resolvable](doctrine#341) thanks to @greg0ire Documentation ------------- - [338: update annotation IDE annotation with current links](doctrine#338) thanks to @Haehnchen Documentation,Improvement ------------------------- - [337: Replace "blacklist" terminology with "ignore"](doctrine#337) thanks to @albe
Yurunsoft
added a commit
to Yurunsoft/doctrine-annotations
that referenced
this pull request
Nov 29, 2020
Release [1.10.4](https://github.com/doctrine/annotations/milestone/25) 1.10.4 ====== - Total issues resolved: **0** - Total pull requests resolved: **8** - Total contributors: **5** - [347: Add support for the new PHP 8 tokens for use statements](doctrine#347) thanks to @stof - [345: Remove calls to TestCase::at()](doctrine#345) thanks to @greg0ire - [343: Allow using PHPUnit 9.3](doctrine#343) thanks to @greg0ire Improvement ----------- - [342: Upgrade phpunit](doctrine#342) thanks to @greg0ire - [332: DocParser: Improve private typehints](doctrine#332) thanks to @jkufner bug --- - [341: Make type in phpdoc resolvable](doctrine#341) thanks to @greg0ire Documentation ------------- - [338: update annotation IDE annotation with current links](doctrine#338) thanks to @Haehnchen Documentation,Improvement ------------------------- - [337: Replace "blacklist" terminology with "ignore"](doctrine#337) thanks to @albe # gpg: Signature made Tue Aug 11 20:55:32 2020 # gpg: using DSA key 1BEDEE0A820BC30D858F9F0C2C3A645671828132 # gpg: Can't check signature: No public key # Conflicts: # composer.json # lib/Doctrine/Common/Annotations/Annotation/Attributes.php # lib/Doctrine/Common/Annotations/DocParser.php # tests/Doctrine/Tests/Common/Annotations/AbstractReaderTest.php # tests/Doctrine/Tests/Common/Annotations/AnnotationReaderTest.php # tests/Doctrine/Tests/Common/Annotations/DocParserTest.php # tests/Doctrine/Tests/Common/Annotations/FileCacheReaderTest.php # tests/Doctrine/Tests/Common/Annotations/SimpleAnnotationReaderTest.php # tests/Doctrine/Tests/Common/Annotations/Ticket/DCOM55Test.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been deprecated as of PHPUnit 9
See sebastianbergmann/phpunit#4297
Note that we still rely on the call order here, I am not the original
author of this test but the order looks like it is pretty important for
this test, or maybe at least for understand it.
Also note that we no longer check that save() is called after all calls
to fetch().