Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update comment block in Module.php as no Module::getAutoloaderConfig() #388

Merged
merged 1 commit into from
Feb 26, 2015

Conversation

samsonasik
Copy link
Contributor

means it must be using composer

@Ocramius Ocramius self-assigned this Feb 26, 2015
@Ocramius Ocramius added this to the 0.9.0 milestone Feb 26, 2015
Ocramius added a commit that referenced this pull request Feb 26, 2015
update comment block in Module.php as no Module::getAutoloaderConfig()
@Ocramius Ocramius merged commit 2b4cbe1 into doctrine:master Feb 26, 2015
@Ocramius
Copy link
Member

@samsonasik thanks!

@samsonasik samsonasik deleted the patch-1 branch February 26, 2015 22:33
@samsonasik
Copy link
Contributor Author

Actually, after I re-think about it, the comment block itself need to be updated to make it work without composer with Zend\Loader ?

Warm regards,

Abdul Malik Ikhsan

Pada 27 Feb 2015, pukul 05.23, Marco Pivetta [email protected] menulis:

@samsonasik thanks!


Reply to this email directly or view it on GitHub.

@samsonasik
Copy link
Contributor Author

or another option. revert this change and add Module::getAutoloaderConfig() ?

Warm regards,

Abdul Malik Ikhsan

Pada 27 Feb 2015, pukul 05.23, Marco Pivetta [email protected] menulis:

@samsonasik thanks!


Reply to this email directly or view it on GitHub.

@Ocramius
Copy link
Member

Ocramius commented Mar 1, 2015

@samsonasik the module does not need to work without composer

@samsonasik
Copy link
Contributor Author

@Ocramius so this file can be deleted, then ?

@mpalourdio
Copy link
Contributor

You'd better delete /src/DoctrineORMModule/Module.php (and report the code in /Module.php before), then you'd need to add a 'classmap' entry in composer.json, that reference the Module class.

@Ocramius
Copy link
Member

Ocramius commented Mar 2, 2015

@mpalourdio no need: the ModuleManager only autoloads what isn't autoloadable.

samsonasik added a commit to samsonasik/DoctrineORMModule that referenced this pull request Mar 2, 2015
@gianarb gianarb mentioned this pull request Apr 24, 2015
oprokidnev pushed a commit to oprokidnev/DoctrineORMModule that referenced this pull request Apr 19, 2016
Added exception for missing required parameter for find_method option as...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants