-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update comment block in Module.php as no Module::getAutoloaderConfig() #388
Conversation
…) means it must be using composer
update comment block in Module.php as no Module::getAutoloaderConfig()
@samsonasik thanks! |
Actually, after I re-think about it, the comment block itself need to be updated to make it work without composer with Zend\Loader ? Warm regards, Abdul Malik Ikhsan Pada 27 Feb 2015, pukul 05.23, Marco Pivetta [email protected] menulis:
|
or another option. revert this change and add Module::getAutoloaderConfig() ? Warm regards, Abdul Malik Ikhsan Pada 27 Feb 2015, pukul 05.23, Marco Pivetta [email protected] menulis:
|
@samsonasik the module does not need to work without composer |
@Ocramius so this file can be deleted, then ? |
You'd better delete /src/DoctrineORMModule/Module.php (and report the code in /Module.php before), then you'd need to add a 'classmap' entry in composer.json, that reference the Module class. |
@mpalourdio no need: the ModuleManager only autoloads what isn't autoloadable. |
I hope I don't missunderstand of doctrine#388 (comment) .
Added exception for missing required parameter for find_method option as...
means it must be using composer