Null empty_option should result in no empty option being included, not a "NULL" select list option #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mjhca any chance to get a failing test for this (separate PR is better, so I can merge this on top of that one) |
Ocramius
added a commit
that referenced
this pull request
Feb 6, 2014
Forced failing unit test for #247
|
Handled in #281 |
Merged
oprokidnev
pushed a commit
to oprokidnev/DoctrineORMModule
that referenced
this pull request
Apr 19, 2016
toOne handles fieldset nicely
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expected behavior: According to ZF2 docs, setting empty_option to NULL instructs a \Zend\Form\Element\Select that it should not add an "empty option" to a select list.
Current behavior: DoctrineORMModule's ElementAnnotationListener ignores a NULL value and includes an empty option (with display string "NULL") in all select lists generated from annotations. This is because of the use of isset() which causes an intentionally set NULL value to be overwritten.
Solution: Replace isset() with array_key_exists().